binutils-apple/ld/testsuite/ld-archive/ at master · theoparis.com/binutils-apple · Tangled

theoparis.com / binutils-apple

0

WIP MachO binutils port assisted by AI I may consider upstreaming this in the future.

0

binutils-apple / ld / testsuite / ld-archive /

at master 33 files

Maciej W. Rozycki PR ld/24600: LD: Add support for file collections as artificial archives 5mo ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: LD: Add options to control mapless archive acceptance Add `--link-mapless' and `--no-link-mapless' LD command-line options, to respectively enable and disable the acceptance of mapless archives on a per-file basis, also with XCOFF targets, enabled by default. Update documentation and add test cases accordingly.

5 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Expand archive verification to group feature Expand archive verification to cover the group feature. Linker error messages for unsatisfied symbol references vary between targets a bit, in particular `arc-*-*' produce duplicate messages and `alpha*-*-osf*' and `alpha*-*-linux*ecoff*' add a "final link failed" message. Factor this in with the error pattern list to match. Usual XFAIL annotations apply.

8 months ago

LD/testsuite: Expand archive verification to group feature Expand archive verification to cover the group feature. Linker error messages for unsatisfied symbol references vary between targets a bit, in particular `arc-*-*' produce duplicate messages and `alpha*-*-osf*' and `alpha*-*-linux*ecoff*' add a "final link failed" message. Factor this in with the error pattern list to match. Usual XFAIL annotations apply.

8 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: BFD: Add general linker support for mapless archives Expand linker mapless archive support from XCOFF targets only across the remaining ones, except for VMS targets whose archive format always has a symbol map. For this tranform BFD code used by AR to produce symbol maps to archive files such as to have a handler supplied to either write a map to a file or convert symbol data to an archive symbol definition table attached to an archive BFD as if read from a symbol map, but using pointers to member BFDs rather than file offsets. Retain XCOFF handling code as it is. Where the archive group feature is used a given archive may be opened multiple times in a single link. If this happens then a reference to a symbol the definition of which is provided by said archive will change from undefined on the first access to the archive to defined on later accesses. The symbol table is pulled from an archive only for undefined references, so if a symbol table has been pulled on first access and then dropped by on-the-fly symbol map generation on a subsequent access, then the symbol table is never re-read. Later on when the linker wants to access it to actually resolve symbol references it won't have been reloaded and a crash would happen on a null pointer dereference. To prevent this from happening add code to `_bfd_compute_and_push_armap' to let the caller request the symbol table to be retained and ask for it when building a symbol map on the fly in the linker. The symbol table will likely be used further down the link anyway. Additionally always check the format of the first member of an archive, even if no symbol map is present, and respect the format determined, so that the correct format is used even if it is not the default one the LD has been configured for, preventing segmentation faults from triggering in `cris-aout' LD with the default (`crisaout') emulation or with the `criself' emulation explicitly requested where archive members are in the ELF format and consequntly removing failures with new tests: cris-aout -FAIL: CRIS regular archive w/o index link (explicit emulation) cris-aout -FAIL: CRIS regular archive w/o index link (implicit emulation) cris-aout -FAIL: CRIS thin archive w/o index link (explicit emulation) cris-aout -FAIL: CRIS thin archive w/o index link (implicit emulation) Update documentation and adjust test cases accordingly now that mapless archives are accepted for link by all targets except for VMS ones, which never produce them in the first place.

5 months ago

PR ld/24600: BFD: Add general linker support for mapless archives Expand linker mapless archive support from XCOFF targets only across the remaining ones, except for VMS targets whose archive format always has a symbol map. For this tranform BFD code used by AR to produce symbol maps to archive files such as to have a handler supplied to either write a map to a file or convert symbol data to an archive symbol definition table attached to an archive BFD as if read from a symbol map, but using pointers to member BFDs rather than file offsets. Retain XCOFF handling code as it is. Where the archive group feature is used a given archive may be opened multiple times in a single link. If this happens then a reference to a symbol the definition of which is provided by said archive will change from undefined on the first access to the archive to defined on later accesses. The symbol table is pulled from an archive only for undefined references, so if a symbol table has been pulled on first access and then dropped by on-the-fly symbol map generation on a subsequent access, then the symbol table is never re-read. Later on when the linker wants to access it to actually resolve symbol references it won't have been reloaded and a crash would happen on a null pointer dereference. To prevent this from happening add code to `_bfd_compute_and_push_armap' to let the caller request the symbol table to be retained and ask for it when building a symbol map on the fly in the linker. The symbol table will likely be used further down the link anyway. Additionally always check the format of the first member of an archive, even if no symbol map is present, and respect the format determined, so that the correct format is used even if it is not the default one the LD has been configured for, preventing segmentation faults from triggering in `cris-aout' LD with the default (`crisaout') emulation or with the `criself' emulation explicitly requested where archive members are in the ELF format and consequntly removing failures with new tests: cris-aout -FAIL: CRIS regular archive w/o index link (explicit emulation) cris-aout -FAIL: CRIS regular archive w/o index link (implicit emulation) cris-aout -FAIL: CRIS thin archive w/o index link (explicit emulation) cris-aout -FAIL: CRIS thin archive w/o index link (implicit emulation) Update documentation and adjust test cases accordingly now that mapless archives are accepted for link by all targets except for VMS ones, which never produce them in the first place.

5 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

LD/testsuite: Expand archive verification to group feature Expand archive verification to cover the group feature. Linker error messages for unsatisfied symbol references vary between targets a bit, in particular `arc-*-*' produce duplicate messages and `alpha*-*-osf*' and `alpha*-*-linux*ecoff*' add a "final link failed" message. Factor this in with the error pattern list to match. Usual XFAIL annotations apply.

8 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

PR ld/24600: LD: Add support for file collections as artificial archives Implement linker support for `--start-lib' and `--end-lib' command-line options and an analogous LIB linker script statement for treating a list of object files as members of an artificial archive. This is built upon BFD's fake archive feature, to support the same command-line options of the GOLD linker being phased out. Usual archive semantics is preserved for such artificial archives, such as symbol resolution rules, archive grouping, and the `--whole-archive' feature, except for the `--no-link-mapless' setting which is ignored as meaningless for such loose file collections which cannot have a symbol map. There is no support for nested archives or other members that are not object files, e.g. if a file supplied as a member archive is a linker script, it will be silently ignored, just as with actual archives. It is unlike with input files passed that are not members of an artificial archive. Update documentation and expand test coverage accordingly.

5 months ago

LD/testsuite: Add tests for archive handling Add basic verification for archives to work, regular and thin, in the link. Refer to PR binutils/33484 and PR binutils/33485 for targets that fail these basic checks, where `ar' fails to add subsequent members to the archive or fails to add symbols from subsequent members to the map respectively, for thin archives. NB symbol names chosen such as to avoid a clash with Z80 CPU registers.

10 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

VMS/BFD: Fix a sign extension issue with archive symbol lookup Symbol binary search code for VMS archive files uses plain `char' data type to cast a difference between characters to data of the `int' type. Consequently the difference is consider unsigned in the range between 0 and 255 on hosts where plain `char' data type is unsigned, resulting in symbol lookup failures, such as with the test expansion included with this change causing regressions as follows: FAIL: Regular archive link FAIL: Thin archive link FAIL: Regular archive plus regular link FAIL: Regular archive plus thin link FAIL: Thin archive plus regular link FAIL: Thin archive plus thin link owing to link failures such as: .../ld/ld-new: tmpdir/abc.o:($DATA$+0x0): undefined reference to `aa' .../ld/ld-new: tmpdir/ab.a(b.obj):($DATA$+0x10): undefined reference to `aa' .../ld/ld-new: tmpdir/abc.o:($DATA$+0x0): undefined reference to `aa' .../ld/ld-new: tmpdir/ab.a(b.obj):($DATA$+0x10): undefined reference to `aa' with the `alpha-dec-vms' target on the `powerpc64le-linux-gnu' host. Use explicit `signed char' data type for the cast then, removing the failures.

8 months ago

LD/testsuite: Expand archive verification to `--whole-archive' feature Expand archive verification to cover the `--whole-archive' feature, adding link map and verbose output matching to verify the correct archive members are added and the unwanted ones omitted. Adjust the linker flags accordingly for XCOFF targets, by switching from the `-bexpall' option to `-unix' (`-bexpfull' would do too, but has some test coverage already, unlike `-unix', which is a superset of the former option), so that additional symbols pulled with `--whole-archive' aren't discarded by linker garbage collection. This test expansion has revealed the lack of thin archive support in AR for Alpha/VMS and XCOFF targets, despite apparent presence of relevant code in the respective BFD backends. With `ar rcT' invocation a regular archive is silently produced instead. Rather than making the relevant tests overly permissive, XFAIL them for the affected targets, referring PR binutils/33600.

8 months ago

VMS/BFD: Fix a sign extension issue with archive symbol lookup Symbol binary search code for VMS archive files uses plain `char' data type to cast a difference between characters to data of the `int' type. Consequently the difference is consider unsigned in the range between 0 and 255 on hosts where plain `char' data type is unsigned, resulting in symbol lookup failures, such as with the test expansion included with this change causing regressions as follows: FAIL: Regular archive link FAIL: Thin archive link FAIL: Regular archive plus regular link FAIL: Regular archive plus thin link FAIL: Thin archive plus regular link FAIL: Thin archive plus thin link owing to link failures such as: .../ld/ld-new: tmpdir/abc.o:($DATA$+0x0): undefined reference to `aa' .../ld/ld-new: tmpdir/ab.a(b.obj):($DATA$+0x10): undefined reference to `aa' .../ld/ld-new: tmpdir/abc.o:($DATA$+0x0): undefined reference to `aa' .../ld/ld-new: tmpdir/ab.a(b.obj):($DATA$+0x10): undefined reference to `aa' with the `alpha-dec-vms' target on the `powerpc64le-linux-gnu' host. Use explicit `signed char' data type for the cast then, removing the failures.

8 months ago