binutils-apple/gdbsupport/ at master · theoparis.com/binutils-apple · Tangled

theoparis.com / binutils-apple

0

WIP MachO binutils port assisted by AI I may consider upstreaming this in the future.

0

binutils-apple / gdbsupport /

at master 1 folder 168 files

Tom de Vries [gdb] Remove '/* *' multi-line comment marker 7w ago

unordered_dense

gdbsupport: bump unordered_dense to 4.8.0 We don't need anything in this release, but I think it doesn't hurt to just stay up to date. The new version has a new include file, stl.h. To keep things clean and separated, move the imported files to a new sub-directory. This requires a small change in gdb/check-include-guards.py, to be able to ignore the whole new directory. Change-Id: Ic8c5d0dd5ea8b6691c99975d6ca78f637175ef42 Approved-By: Tom Tromey <tom@tromey.com>

9 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdb] Fix whitespace in *.def Add indent-with-non-tab for *.def in gdb*/.gitattributes. Fix whitespace in the *.def files in gdb*, and add these files to the clean list in gdb/contrib/check-whitespace-pre-commit.py. Tested on x86_64-linux. Approved-By: Tom Tromey <tom@tromey.com>

7 months ago

ChangeLog-2020-2021

gdb: move remaining ChangeLogs to legacy files In commit: commit f069ea46a03ae868581d1c852da28e979ea1245a Date: Sat Jul 3 16:29:08 2021 -0700 Rename gdb/ChangeLog to gdb/ChangeLog-2021 The gdb/ChangeLog file was renamed, but all of the other ChangeLog files relating to gdb were left in place. As I understand things, the no ChangeLogs policy applies to all the GDB related directories, so this commit renames all of the remaining GDB related ChangeLog files. As with the original commit, the intention behind this commit is to hopefully stop people merging ChangeLog entries by mistake. The renames carried out in this commit are: gdb/doc/ChangeLog -> gdb/doc/ChangeLog-1991-2021 gdb/stubs/ChangeLog -> gdb/stubs/ChangeLog-2012-2020 gdb/testsuite/ChangeLog -> gdb/testsuite/ChangeLog-2014-2021 gdbserver/ChangeLog -> gdbserver/ChangeLog-2002-2021 gdbsupport/ChangeLog -> gdbsupport/ChangeLog-2020-2021

5 years ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdbsupport] Regenerate Makefile.in The buildbot complains about an out-of-date Makefile.in. Fix this by regenerating it from Makefile.am using automake.

6 months ago

Move gdbsupport to the top level This patch moves the gdbsupport directory to the top level. This is the next step in the ongoing project to move gdbserver to the top level. The bulk of this patch was created by "git mv gdb/gdbsupport gdbsupport". This patch then adds a build system to gdbsupport and wires it into the top level. Then it changes gdb to use the top-level build. gdbserver, on the other hand, is not yet changed. It still does its own build of gdbsupport. ChangeLog 2020-01-14 Tom Tromey <tom@tromey.com> * src-release.sh (GDB_SUPPORT_DIRS): Add gdbsupport. * MAINTAINERS: Add gdbsupport. * configure: Rebuild. * configure.ac (configdirs): Add gdbsupport. * gdbsupport: New directory, move from gdb/gdbsupport. * Makefile.def (host_modules, dependencies): Add gnulib. * Makefile.in: Rebuild. gdb/ChangeLog 2020-01-14 Tom Tromey <tom@tromey.com> * nat/x86-linux-dregs.c: Include configh.h. * nat/linux-ptrace.c: Include configh.h. * nat/linux-btrace.c: Include configh.h. * defs.h: Include config.h, bfd.h. * configure.ac: Don't source common.host. (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files. * configure: Rebuild. * acinclude.m4: Update path. * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables. (CONFIG_SRC_SUBDIR): Remove gdbsupport. (INTERNAL_CFLAGS_BASE): Add INCSUPPORT. (CLIBS): Add LIBSUPPORT. (CDEPS): Likewise. (COMMON_SFILES): Remove gdbsupport files. (HFILES_NO_SRCDIR): Likewise. (stamp-version): Update path to create-version.sh. (ALLDEPFILES): Remove gdbsupport files. gdb/gdbserver/ChangeLog 2020-01-14 Tom Tromey <tom@tromey.com> * server.h: Include config.h. * gdbreplay.c: Include config.h. * configure: Rebuild. * configure.ac: Don't source common.host. * acinclude.m4: Update path. * Makefile.in (INCSUPPORT): New variable. (INCLUDE_CFLAGS): Add INCSUPPORT. (SFILES): Update paths. (version-generated.c): Update path to create-version.sh. (gdbsupport/%-ipa.o, gdbsupport/%.o): Update paths. gdbsupport/ChangeLog 2020-01-14 Tom Tromey <tom@tromey.com> * common-defs.h: Add GDBSERVER case. Update includes. * acinclude.m4, aclocal.m4, config.in, configure, configure.ac, Makefile.am, Makefile.in, README: New files. * Moved from ../gdb/gdbsupport/ Change-Id: I07632e7798635c1bab389bf885971e584fb4bb78

7 years ago

gdb: move libiberty.m4 to gdbsupport This is used by gdb, gdbsupport, and gdbserver. We want to use it in the sim tree too. Move it to gdbsupport which is meant as the common sharing space for these projects. Approved-By: Tom Tromey <tom@tromey.com>

2 years ago

[gdbsupport] Rerun autoreconf -f Rerun autoreconf -f in gdbsupport, reverting "behaviour" -> "behavior" changes in generated files aclocal.m4 and configure.

2 years ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

block-signals.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

btrace-common.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

btrace-common.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

check-defines.el

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

common-debug.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb/elfread: add debug output for GNU ifunc resolution Add some debug prints throughout the ifunc resolution code, to be able to better understand what GDB does. Add the new "set debug gnu-ifunc" knob to control it. Add the debug_prefixed_printf_cond_func macro to implement gnu_ifunc_debug_printf_func, that takes an explicit function name. This is needed to avoid showing "operator()" as the function name in the debug message. Here is a sample session with the new debug output enabled. (gdb) b the_function [gnu-ifunc] elf_gnu_ifunc_resolve_name: resolving name "the_function" [gnu-ifunc] elf_gnu_ifunc_resolve_by_cache: resolving "the_function" by cache [gnu-ifunc] elf_gnu_ifunc_resolve_by_cache: cache miss for "the_function" [gnu-ifunc] elf_gnu_ifunc_resolve_by_got: resolving "the_function" by GOT [gnu-ifunc] elf_gnu_ifunc_resolve_by_got: GOT entry "the_function@got.plt" points to 0x7ffff7fb7036 [gnu-ifunc] elf_gnu_ifunc_record_cache: recording cache entry for "the_function" at 0x7ffff7fb7036 [gnu-ifunc] elf_gnu_ifunc_record_cache: minimal symbol "the_function@plt" at 0x7ffff7fb7030 does not match addr 0x7ffff7fb7036, not caching [gnu-ifunc] elf_gnu_ifunc_resolve_by_got: GOT entry "the_function@got.plt" points to 0x7ffff7fb2036 [gnu-ifunc] elf_gnu_ifunc_record_cache: recording cache entry for "the_function" at 0x7ffff7fb2036 [gnu-ifunc] elf_gnu_ifunc_record_cache: minimal symbol "the_function@plt" at 0x7ffff7fb2030 does not match addr 0x7ffff7fb2036, not caching [gnu-ifunc] elf_gnu_ifunc_resolve_by_got: failed to resolve "the_function" by GOT [gnu-ifunc] elf_gnu_ifunc_resolve_name: failed to resolve name "the_function" Breakpoint 2 at gnu-indirect-function resolver at 0x7ffff7fa80e9 (gdb) c Continuing. [gnu-ifunc] elf_gnu_ifunc_resolver_stop: stop on resolver for "the_function" [gnu-ifunc] elf_gnu_ifunc_resolver_stop: created resolver return breakpoint at 0x7ffff7fd7186 [gnu-ifunc] elf_gnu_ifunc_resolver_return_stop: stop on resolver return [gnu-ifunc] elf_gnu_ifunc_resolver_return_stop: resolver for "the_function" returned resolved address=0x7ffff7fad0e9, resolved pc=0x7ffff7fad0e9 [gnu-ifunc] elf_gnu_ifunc_record_cache: recording cache entry for "the_function" at 0x7ffff7fad0e9 [gnu-ifunc] elf_gnu_ifunc_record_cache: cached "the_function" -> 0x7ffff7fad0e9 in objfile /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.base/ifunc-resolver/libimpl.so Breakpoint 2, the_function_impl_0 (caller_id=1) at /home/simark/src/binutils-gdb/gdb/testsuite/gdb.base/ifunc-resolver-libimpl.c:25 25 the_function_last_caller_id = caller_id; /* break-in-impl */ Change-Id: I64f667e3457feaedfe9bb530de58faaf22545fa5 Reviewed-By: Eli Zaretskii <eliz@gnu.org> Approved-by: Kevin Buettner <kevinb@redhat.com>

5 months ago

[gdb] Remove unnecessary defs.h/common-defs.h includes I asked an AI to review a patch that added a new file, and it mentioned I should add an include of defs.h as first include. That used to be true, but since commit 18d2988e5da ("gdb, gdbserver, gdbsupport: remove includes of early headers") that's not the case anymore. Error out when encountering a second include of defs.h, and remove a few of those. While we're at it, do the same for gdbsupport/common-defs.h and gdbserver/server.h. Tested by rebuilding gdb on x86_64-linux. V1 submitted here [1]. Changes in v1: - also handle gdbserver/server.h - change error message to use "manually" instead of "twice" Approved-By: Simon Marchi <simon.marchi@efficios.com> [1] https://sourceware.org/pipermail/gdb-patches/2026-April/226694.html

3 months ago

common-exceptions.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

common-exceptions.h

Allow styling when using throw_* functions The throw_* family of functions use the varargs constructor for gdb_exception, which then calls string_vprintf. This means that styling cannot be applied here by gdb. This patch changes this code to use a client-supplied formatting function. For gdbserver this remains string_vprintf, but for gdb it now allows styling. I did look at unifying 'error' and the throw_* functions a bit more, but this would have meant unravelling some IPA code.

3 months ago

common-gdbthread.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

common-inferior.cc

gdb/gdbserver: move argument setting complexity into gdbsupport/ This commit removes some uses of gdb::argv_vec from GDB. The gdb::argv_vec class exists in part due to our need to convert from one container type to another in a few places, and I think by using templates we can push this conversion down into gdbsupport/common-inferior.{cc,h} and remove the conversion logic from higher level code in GDB. This should make core GDB simpler. For examples of this simplification, see python/py-inferior.c, remote.c, and unittests/remote-arg-selftests.c, where this commit has allowed for the removal of some code that only exists in order to convert the container type. Ideally I'd like to see all uses of gdb::argv_vec removed, but I'm still not sure about the use in nat/fork-inferior.c, I think its use there might be the best solution, so for now at least, I have no plans to touch that code. There should be no user visible changes after this commit. Approved-By: Tom Tromey <tom@tromey.com>

2 years ago

common-inferior.h

gdb/gdbserver: move argument setting complexity into gdbsupport/ This commit removes some uses of gdb::argv_vec from GDB. The gdb::argv_vec class exists in part due to our need to convert from one container type to another in a few places, and I think by using templates we can push this conversion down into gdbsupport/common-inferior.{cc,h} and remove the conversion logic from higher level code in GDB. This should make core GDB simpler. For examples of this simplification, see python/py-inferior.c, remote.c, and unittests/remote-arg-selftests.c, where this commit has allowed for the removal of some code that only exists in order to convert the container type. Ideally I'd like to see all uses of gdb::argv_vec removed, but I'm still not sure about the use in nat/fork-inferior.c, I think its use there might be the best solution, so for now at least, I have no plans to touch that code. There should be no user visible changes after this commit. Approved-By: Tom Tromey <tom@tromey.com>

2 years ago

common-regcache.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

common-regcache.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdb] Remove '/* *' multi-line comment marker Doxygen supports a multi-line comment marker '/**'. In GDB we're using something slightly similar: '/* *' [1]. Drop this and just use '/*'. Result of: ... $ find gdb* -type f -name "*.[ch]" -o -name "*.def" \ | egrep -v /testsuite/ \ | xargs sed -i 's%/\* \* %/* %' ... and manually reverting the change in the comment for BINOP_MUL in gdb/std-operator.def. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34186 Approved-By: Kevin Buettner <kevinb@redhat.com> Approved-By: Tom Tromey <tom@tromey.com> [1] https://sourceware.org/gdb/wiki/DoxygenForGDB

1 month ago

common-utils.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb: refuse to produce .gdb_index when skeletonless type units are present Running test gdb.dwarf2/fission-with-type-unit.exp with the cc-with-gdb-index target board fails with: (gdb) maint expand-symtabs /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:3064: internal-error: cutu_reader: Assertion `sig_type->signature == cu->header.signature' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. ----- Backtrace ----- FAIL: gdb.dwarf2/fission-with-type-unit.exp: maint expand-symtabs (GDB internal error) This is a consequence of .gdb_index not supporting skeletonless type units in .dwo files. That is, type units in .dwo files that don't have a corresponding skeleton (or stub) in the main file. For context: in DWARF 4, gcc 4.x used to create skeletons for type units in .dwo files, but subsequent versions don't. DWARF 5 doesn't have support for type unit skeletons at all. So skeletons for type units are mostly a historical curiosity at this point, the norm is to not have them. Here's what leads up to the crash. First, this is what is in the main file's .debug_info section (the first and last CUs are dummy CUs added by the testsuite): Compilation Unit @ offset 0: Length: 0x8 (32-bit) Version: 4 Abbrev Offset: 0 Pointer Size: 8 <0><b>: Abbrev Number: 1 (DW_TAG_compile_unit) Compilation Unit @ offset 0xc: Length: 0x15 (32-bit) Version: 5 Unit Type: DW_UT_skeleton (4) Abbrev Offset: 0x6 Pointer Size: 8 DWO ID: 0xf00d <0><20>: Abbrev Number: 1 (DW_TAG_compile_unit) <21> DW_AT_dwo_name : (strp) (offset: 0): fission-with-type-unit-dw.dwo Compilation Unit @ offset 0x25: Length: 0x8 (32-bit) Version: 4 Abbrev Offset: 0xe Pointer Size: 8 <0><30>: Abbrev Number: 1 (DW_TAG_compile_unit) And here is what is in the fission-with-type-unit-dw.dwo file (one TU and the CU): Contents of the .debug_info.dwo section: Compilation Unit @ offset 0: Length: 0x1d (32-bit) Version: 5 Unit Type: DW_UT_type (2) Abbrev Offset: 0 Pointer Size: 8 Signature: 0xcafe Type Offset: 0x19 <0><18>: Abbrev Number: 1 (DW_TAG_type_unit) <1><19>: Abbrev Number: 2 (DW_TAG_base_type) <1a> DW_AT_byte_size : (sdata) 4 <1b> DW_AT_encoding : (sdata) 5 (signed) <1c> DW_AT_name : (string) int <1><20>: Abbrev Number: 0 Contents of the .debug_info.dwo section: Compilation Unit @ offset 0: Length: 0x2d (32-bit) Version: 5 Unit Type: DW_UT_split_compile (5) Abbrev Offset: 0 Pointer Size: 8 DWO ID: 0xf00d <0><14>: Abbrev Number: 3 (DW_TAG_compile_unit) <1><15>: Abbrev Number: 4 (DW_TAG_base_type) <16> DW_AT_byte_size : (sdata) 4 <17> DW_AT_encoding : (sdata) 5 (signed) <18> DW_AT_name : (string) int <1><1c>: Abbrev Number: 5 (DW_TAG_variable) <1d> DW_AT_name : (string) global_var <28> DW_AT_type : (ref4) <0x15>, int <2c> DW_AT_location : (exprloc) 3 byte block: 8 c 9f (DW_OP_const1u: 12; DW_OP_stack_value) <1><30>: Abbrev Number: 0 After loading the above in GDB, here is what is in GDB's mind (contents of dwarf2_per_bfd::all_units): - CU at offset 0x0 of .debug_info in fission-with-type-unit -- dummy - CU at offset 0xc of .debug_info in fission-with-type-unit - CU at offset 0x25 of .debug_info in fission-with-type-unit -- dummy - TU at offset 0x0 of .debug_info.dwo in fission-with-type-unit-dw.dwo This is correct. Then, this is the generated .gdb_index: Contents of the .gdb_index section: Version 9 CU table: [ 0] 0 - 0xb -- dummy [ 1] 0xc - 0x24 [ 2] 0x25 - 0x30 -- dummy TU table: [ 0] 0 0x19 000000000000cafe Address table: Symbol table: [ 3] global_var: 1 [static, variable] [754] int: 1 [static, type] Shortcut table: Language of main: unknown: 0 Name of main: <unknown> The TU table says that there exists a TU at offset 0. Unfortunately, there is no way for a reader of that index to know that this TU is really in a .dwo file, not in the main file. So when GDB loads this index back (creating dwarf2_per_bfd::all_units from .gdb_index this time, rather than walking the debug info), this is what is in its mind: - CU at offset 0x0 of .debug_info in fission-with-type-unit -- dummy - TU at offset 0x0 of .debug_info in fission-with-type-unit - CU at offset 0xc of .debug_info in fission-with-type-unit - CU at offset 0x25 of .debug_info in fission-with-type-unit -- dummy GDB now incorrectly believes there's a TU at offset 0 of .debug_info in the main file, which is wrong. When trying to expand that TU with "maint expand-symtabs", we're not really reading the TU, so we hit the assert checking that the signature in the TU header matches what was given by the index. The .debug_names format has a way to list the TUs found in the .dwo files, called the "foreign TU list" (see section 6.1.1.2 "Structure of the Name Index" of DWARF 5). That list only includes the signature of the type, and there is some capability to figure out which .dwo file contains that type unit. The .gdb_index format does not have something like that. We could try to retrofit such a feature in the .gdb_index format, but I think we prefer to put our efforts on the standard .debug_names format. To avoid producing a misleading index like shown above, I propose to make GDB refuse to produce an index if there exists a skeletonless type unit. This patch implements that by looking at section of all signatured_types. If the containing section ends with .dwo, then this is a skeletonless type unit. As a reminder: if a unit has a skeleton, the dwarf2_per_cu section will point at the skeleton section, in the main file. If the unit does not have a skeleton, the dwarf2_per_cu section will point at the section in the .dwo file. All .dwo section names end with ".dwo". Add a "endswith" utils function to help with that. With this patch, running the gdb.dwarf/fission-with-type-unit.exp leads to a compilation failure: gdb compile failed, Error while writing index for `/home/smarchi/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/fission-with-type-unit/.tmp/fission-with-type-unit': Found skeletonless type units, unable to produce .gdb_index. Consider using .debug_names instead. ... which makes the test "untested". Add a new test, gdb.dwarf2/gdb-index-skeletonless-tu.exp, to verify the new error path. Change-Id: I1e2e0204c9c2b48763aa99ce63521ae4a5262b22 Reviewed-By: Eli Zaretskii <eliz@gnu.org> Approved-By: Tom Tromey <tom@tromey.com>

8 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

compiler-type.m4

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

GDB: aarch64-linux: Fix build failure on musl systems When building against musl (e.g. on Alpine Linux), the following error happens: CXX linux-aarch64-low.o In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:48: /home/bauermann/src/binutils-gdb/gdbserver/../gdb/nat/aarch64-gcs-linux.h:36:8: error: redefinition of 'struct user_gcs' 36 | struct user_gcs | ^~~~~~~~ In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:36: /usr/include/asm/ptrace.h:329:8: note: previous definition of 'struct user_gcs' 329 | struct user_gcs { | ^~~~~~~~ make[2]: *** [Makefile:565: linux-aarch64-low.o] Error 1 aarch64-linux-tdep.c fails to build in the same way. This happens because aarch64-gcs-linux-ptrace.h uses GCS_MAGIC to see whether the system headers have GCS-related definitions. The problem is that GCS_MAGIC is defined in <asm/sigcontext.h> while struct gcs_user is defined in <asm/ptrace.h>. It's fine on glibc systems because in the set of system headers that linux-aarch64-low.cc and aarch64-linux-tdep.c include, <asm/sigcontext.h> ends up being included implicitly as well. This doesn't happen when using musl's headers though. There isn't a macro in <asm/ptrace.h> whose presence is correlated with the presence of the struct user_gcs definition, so a configure check is needed to detect it and conditionally define the struct. Note that there's another build issue with musl, described in PR gdb/33747 affecting compilation of gdb/ser-unix.c. In order to be able to test this patch, I applied the patch in comment 11 there. Tested with a native build on an Alpine Linux aarch64 system, and also verified that all gdb.arch/aarch64-gcs*.exp tests pass on it. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33926 Co-authored-by: Chris Packham <judge.packham@gmail.com> Approved-By: Luis Machado <luis.machado.foss@gmail.com>

5 months ago

GDB: aarch64-linux: Fix build failure on musl systems When building against musl (e.g. on Alpine Linux), the following error happens: CXX linux-aarch64-low.o In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:48: /home/bauermann/src/binutils-gdb/gdbserver/../gdb/nat/aarch64-gcs-linux.h:36:8: error: redefinition of 'struct user_gcs' 36 | struct user_gcs | ^~~~~~~~ In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:36: /usr/include/asm/ptrace.h:329:8: note: previous definition of 'struct user_gcs' 329 | struct user_gcs { | ^~~~~~~~ make[2]: *** [Makefile:565: linux-aarch64-low.o] Error 1 aarch64-linux-tdep.c fails to build in the same way. This happens because aarch64-gcs-linux-ptrace.h uses GCS_MAGIC to see whether the system headers have GCS-related definitions. The problem is that GCS_MAGIC is defined in <asm/sigcontext.h> while struct gcs_user is defined in <asm/ptrace.h>. It's fine on glibc systems because in the set of system headers that linux-aarch64-low.cc and aarch64-linux-tdep.c include, <asm/sigcontext.h> ends up being included implicitly as well. This doesn't happen when using musl's headers though. There isn't a macro in <asm/ptrace.h> whose presence is correlated with the presence of the struct user_gcs definition, so a configure check is needed to detect it and conditionally define the struct. Note that there's another build issue with musl, described in PR gdb/33747 affecting compilation of gdb/ser-unix.c. In order to be able to test this patch, I applied the patch in comment 11 there. Tested with a native build on an Alpine Linux aarch64 system, and also verified that all gdb.arch/aarch64-gcs*.exp tests pass on it. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33926 Co-authored-by: Chris Packham <judge.packham@gmail.com> Approved-By: Luis Machado <luis.machado.foss@gmail.com>

5 months ago

GDB: aarch64-linux: Fix build failure on musl systems When building against musl (e.g. on Alpine Linux), the following error happens: CXX linux-aarch64-low.o In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:48: /home/bauermann/src/binutils-gdb/gdbserver/../gdb/nat/aarch64-gcs-linux.h:36:8: error: redefinition of 'struct user_gcs' 36 | struct user_gcs | ^~~~~~~~ In file included from /home/bauermann/src/binutils-gdb/gdbserver/linux-aarch64-low.cc:36: /usr/include/asm/ptrace.h:329:8: note: previous definition of 'struct user_gcs' 329 | struct user_gcs { | ^~~~~~~~ make[2]: *** [Makefile:565: linux-aarch64-low.o] Error 1 aarch64-linux-tdep.c fails to build in the same way. This happens because aarch64-gcs-linux-ptrace.h uses GCS_MAGIC to see whether the system headers have GCS-related definitions. The problem is that GCS_MAGIC is defined in <asm/sigcontext.h> while struct gcs_user is defined in <asm/ptrace.h>. It's fine on glibc systems because in the set of system headers that linux-aarch64-low.cc and aarch64-linux-tdep.c include, <asm/sigcontext.h> ends up being included implicitly as well. This doesn't happen when using musl's headers though. There isn't a macro in <asm/ptrace.h> whose presence is correlated with the presence of the struct user_gcs definition, so a configure check is needed to detect it and conditionally define the struct. Note that there's another build issue with musl, described in PR gdb/33747 affecting compilation of gdb/ser-unix.c. In order to be able to test this patch, I applied the patch in comment 11 there. Tested with a native build on an Alpine Linux aarch64 system, and also verified that all gdb.arch/aarch64-gcs*.exp tests pass on it. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33926 Co-authored-by: Chris Packham <judge.packham@gmail.com> Approved-By: Luis Machado <luis.machado.foss@gmail.com>

5 months ago

create-version.sh

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

default-init-alloc.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdbsupport: add gdb::ranges::views::enumerate util Add a "enumerate" utility, that acts pretty much like Python's enumerate(). It makes the code slightly nicer, for when you would otherwise need to handle the counter by hand. It can be used like this: std::vector<int> my_vector; for (auto [i, val] : gdb::ranges::views::enumerate (my_vector)) ... `i` will hold the 0-based index of the current iteration, and `val` will be a reference to the value of the current iteration. The name is chosen to match std::ranges::views::enumerate from C++23, making it easy to switch to that eventually. Change-Id: I1870ab50537bcf54bba44a30a0b01ab397be16e3

5 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Use enum types for remote fileio flags This changes gdbsupport/fileio.h to use enums with underlying types for the various constants -- open flags, modes, and lseek flags. These types replace #defines that were previously used. Then, this fixes all the users of these flags. This found a few bugs. Some of these were pedantic (using the constant 0700 where perhaps FILEIO_S_IRWXU would be more precise), but sparc64-tdep.c confused host and remote flags. Also, I believe solib-rocm.c had a couple of arguments in the wrong order. I also found that gdb/remote-fileio.c had essentially duplicated some code from gdbsupport. This patch removes the duplicates. New in v2: - The lseek enum is anonymous, the type itself isn't used, just the constants Approved-By: Simon Marchi <simon.marchi@efficios.com>

5 months ago

Use enum types for remote fileio flags This changes gdbsupport/fileio.h to use enums with underlying types for the various constants -- open flags, modes, and lseek flags. These types replace #defines that were previously used. Then, this fixes all the users of these flags. This found a few bugs. Some of these were pedantic (using the constant 0700 where perhaps FILEIO_S_IRWXU would be more precise), but sparc64-tdep.c confused host and remote flags. Also, I believe solib-rocm.c had a couple of arguments in the wrong order. I also found that gdb/remote-fileio.c had essentially duplicated some code from gdbsupport. This patch removes the duplicates. New in v2: - The lseek enum is anonymous, the type itself isn't used, just the constants Approved-By: Simon Marchi <simon.marchi@efficios.com>

5 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

filtered-iterator.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb, gdbsupport, gdbserver: add support for printf 't' length modifier Tom de Vries reported [1] that a use of the `t` printf length modifier (used for ptrdiff_t) breaks "set debug dwarf-die 1": +break -qualified main Reading Reading compcomp unit at offset unit at offset 0x00x39 Reading comp unit at offset 0x1a8 Reading comp unit at offset 0x1e9 Reading comp unit at offset 0x2c5 Reading comp unit at offset 0x2a2 Reading comp unit at offset 0x904 Unrecognized format specifier 't' in printf This use is in dwarf2/read.c: gdb_printf (gdb_stdlog, "Read die from %s@0x%tx of %s:\n", m_die_section->get_name (), (begin_info_ptr - m_die_section->buffer), bfd_get_filename (m_abfd)); Add support for the `t` length modifier in format_pieces, which gdb_printf ultimately uses (through ui_out::vmessage). Modify the three users of format_pieces: gdb's printf command, gdb's ui_out::vmessage function and gdbserver's ax_printf function. The implementation is mostly copied from what we do for size_t. Since format_pieces is also used to implement the printf command, this patch brings user-visible changes. Before: (gdb) printf "%td\n", -123 ❌️ Unrecognized format specifier 't' in printf After: (gdb) printf "%td\n", -123 -123 [1] https://inbox.sourceware.org/gdb-patches/d4ccce34-aad5-4e3d-8fc9-efb2fc11275c@suse.de/ Change-Id: Ie9fce78f5f48082d8f8a9ca2847b5ae26acaa60d Approved-By: Tom Tromey <tom@tromey.com>

6 months ago

gdb, gdbsupport, gdbserver: add support for printf 't' length modifier Tom de Vries reported [1] that a use of the `t` printf length modifier (used for ptrdiff_t) breaks "set debug dwarf-die 1": +break -qualified main Reading Reading compcomp unit at offset unit at offset 0x00x39 Reading comp unit at offset 0x1a8 Reading comp unit at offset 0x1e9 Reading comp unit at offset 0x2c5 Reading comp unit at offset 0x2a2 Reading comp unit at offset 0x904 Unrecognized format specifier 't' in printf This use is in dwarf2/read.c: gdb_printf (gdb_stdlog, "Read die from %s@0x%tx of %s:\n", m_die_section->get_name (), (begin_info_ptr - m_die_section->buffer), bfd_get_filename (m_abfd)); Add support for the `t` length modifier in format_pieces, which gdb_printf ultimately uses (through ui_out::vmessage). Modify the three users of format_pieces: gdb's printf command, gdb's ui_out::vmessage function and gdbserver's ax_printf function. The implementation is mostly copied from what we do for size_t. Since format_pieces is also used to implement the printf command, this patch brings user-visible changes. Before: (gdb) printf "%td\n", -123 ❌️ Unrecognized format specifier 't' in printf After: (gdb) printf "%td\n", -123 -123 [1] https://inbox.sourceware.org/gdb-patches/d4ccce34-aad5-4e3d-8fc9-efb2fc11275c@suse.de/ Change-Id: Ie9fce78f5f48082d8f8a9ca2847b5ae26acaa60d Approved-By: Tom Tromey <tom@tromey.com>

6 months ago

forward-scope-exit.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

function-view.h

Include traits.h in function-view.h function-view.h uses gdb::Or but does not include gdbsupport/traits.h. This patch corrects the oversight.

2 months ago

gdb-checked-static-cast.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb_binary_search.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Introduce character-printing class This patch introduces a new class for printing character and string literals by rewriting some code in valprint. The new class is designed to be subclassed to provide language-specific character printing.

7 months ago

gdb_proc_service.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Use gdb::Requires in gdb::ref_ptr Andrew pointed out that the use of is_convertible in gdb::ref_ptr is incorrect, and that it should instead check the value. This can easily be done using gdb::Requires. Approved-By: Andrew Burgess <aburgess@redhat.com>

2 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb_splay_tree.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb_tilde_expand.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb_tilde_expand.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb_unique_ptr.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdb] Remove '/* *' multi-line comment marker Doxygen supports a multi-line comment marker '/**'. In GDB we're using something slightly similar: '/* *' [1]. Drop this and just use '/*'. Result of: ... $ find gdb* -type f -name "*.[ch]" -o -name "*.def" \ | egrep -v /testsuite/ \ | xargs sed -i 's%/\* \* %/* %' ... and manually reverting the change in the comment for BINOP_MUL in gdb/std-operator.def. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34186 Approved-By: Kevin Buettner <kevinb@redhat.com> Approved-By: Tom Tromey <tom@tromey.com> [1] https://sourceware.org/gdb/wiki/DoxygenForGDB

1 month ago

intrusive_list.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

iteration-status.h

gdbsupport: remove iteration_status_str When building with g++ 8 (on Alma Linux 8), we get: CXX ada-exp.o In file included from /binutils-gdb/gdb/../gdbsupport/array-view.h:24, from /binutils-gdb/gdb/../gdbsupport/common-utils.h:27, from /binutils-gdb/gdb/../gdbsupport/common-defs.h:214, from /binutils-gdb/gdb/defs.h:26, from <command-line>: /binutils-gdb/gdb/../gdbsupport/iteration-status.h: In function ‘constexpr const char* iteration_status_str(iteration_status)’: /binutils-gdb/gdb/../gdbsupport/gdb_assert.h:43:22: error: call to non-‘constexpr’ function ‘void internal_error_loc(const char*, int, const char*, ...)’ internal_error_loc (__FILE__, __LINE__, _("%s: " message), __func__, \ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##__VA_ARGS__) ~~~~~~~~~~~~~~ /binutils-gdb/gdb/../gdbsupport/iteration-status.h:45:3: note: in expansion of macro ‘gdb_assert_not_reached’ gdb_assert_not_reached ("invalid iteration_status value"); ^~~~~~~~~~~~~~~~~~~~~~ It turns out that iteration_status_str isn't used, it apparently was only used transiently in my series. Remove it to fix the build failure. Change-Id: Icb43d4d719ad94a3eafa5fd55c81a56cbe0da91d

3 months ago

iterator-range.h

[gdbsupport] Add parameterless iterator_range constructor I noticed that there's no convenient way to create an empty range in iterator_range. Add this.

3 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

next-iterator.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb, gdbserver, gdbsupport: replace many uses of strcmp with streq Replace all occurrences of: strcmp (...) == 0 strcmp (...) != 0 !strcmp (...) 0 == strcmp (...) strcmp (...) directly used as a boolean predicate with the equivalent expression using streq. This is for consistency (we already use streq as some places in the testsuite) but also for clarity. I think that streq is clearer on the intent than strcmp. It's also a bit shorter. Change-Id: Ibbf5261b1872c240bc0c982c147f6a5477275a91 Approved-By: Andrew Burgess <aburgess@redhat.com>

4 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

owning_intrusive_list.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Do not use ENUM_BITFIELD C++ always allows enum bitfields, so gdb no longer needs to use the ENUM_BITFIELD macro. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32821 Approved-By: Andrew Burgess <aburgess@redhat.com> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>

2 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdbsupport] Fix get_print_cell use in threads PR gdb/33753 reports problems with get_print_cell when used from threads. Fix this by making the two static variables in get_print_cell thread_local. Tested on x86_64-linux. Approved-By: Simon Marchi <simon.marchi@efficios.com> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33753

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

refcounted-object.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

reference-to-pointer-iterator.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

[gdb] Remove unnecessary defs.h/common-defs.h includes I asked an AI to review a patch that added a new file, and it mentioned I should add an include of defs.h as first include. That used to be true, but since commit 18d2988e5da ("gdb, gdbserver, gdbsupport: remove includes of early headers") that's not the case anymore. Error out when encountering a second include of defs.h, and remove a few of those. While we're at it, do the same for gdbsupport/common-defs.h and gdbserver/server.h. Tested by rebuilding gdb on x86_64-linux. V1 submitted here [1]. Changes in v1: - also handle gdbserver/server.h - change error message to use "manually" instead of "twice" Approved-By: Simon Marchi <simon.marchi@efficios.com> [1] https://sourceware.org/pipermail/gdb-patches/2026-April/226694.html

3 months ago

gdb/gdbserver: move argument setting complexity into gdbsupport/ This commit removes some uses of gdb::argv_vec from GDB. The gdb::argv_vec class exists in part due to our need to convert from one container type to another in a few places, and I think by using templates we can push this conversion down into gdbsupport/common-inferior.{cc,h} and remove the conversion logic from higher level code in GDB. This should make core GDB simpler. For examples of this simplification, see python/py-inferior.c, remote.c, and unittests/remote-arg-selftests.c, where this commit has allowed for the removal of some code that only exists in order to convert the container type. Ideally I'd like to see all uses of gdb::argv_vec removed, but I'm still not sure about the use in nat/fork-inferior.c, I think its use there might be the best solution, so for now at least, I have no plans to touch that code. There should be no user visible changes after this commit. Approved-By: Tom Tromey <tom@tromey.com>

2 years ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

run-time-clock.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

run-time-clock.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

safe-iterator.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

safe-strerror.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

scoped_ignore_signal.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

scoped_ignore_sigttou.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

scoped_restore.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

scoped_signal_handler.h

gdb: remove an unintended #undef An #undef seems to have sneaked into gdbsupport/scoped_signal_handler.h. This causes the HAVE_SIGACTION macro to be cleared unintentionally. Remove the line. Approved-By: Tom Tromey <tom@tromey.com>

3 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

signals-state-save-restore.cc

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

signals-state-save-restore.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

gdb, gdbserver, gdbsupport: replace many uses of strcmp with streq Replace all occurrences of: strcmp (...) == 0 strcmp (...) != 0 !strcmp (...) 0 == strcmp (...) strcmp (...) directly used as a boolean predicate with the equivalent expression using streq. This is for consistency (we already use streq as some places in the testsuite) but also for clarity. I think that streq is clearer on the intent than strcmp. It's also a bit shorter. Change-Id: Ibbf5261b1872c240bc0c982c147f6a5477275a91 Approved-By: Andrew Burgess <aburgess@redhat.com>

4 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Add lock_guard to thread_pool::thread_count I think there's a possible race when calling thread_pool::thread_count from a worker thread, if the main thread changes the number of threads at the same time. When this code was initially written, we didn't worry about this, because this was only accessed from the main thread. This is no longer the case, though. This patch fixes any potential problem by adding a lock_guard to the method. This doesn't seem too harmful because this is not called very much and because I doubt this lock is highly contended. While doing this I noticed that thread_pool::do_post_task could access m_sized_at_least_once and m_thread_count without holding the lock. This patch changes this method as well. Approved-by: Kevin Buettner <kevinb@redhat.com>

4 months ago

Add lock_guard to thread_pool::thread_count I think there's a possible race when calling thread_pool::thread_count from a worker thread, if the main thread changes the number of threads at the same time. When this code was initially written, we didn't worry about this, because this was only accessed from the main thread. This is no longer the case, though. This patch fixes any potential problem by adding a lock_guard to the method. This doesn't seem too harmful because this is not called very much and because I doubt this lock is highly contended. While doing this I noticed that thread_pool::do_post_task could access m_sized_at_least_once and m_thread_count without holding the lock. This patch changes this method as well. Approved-by: Kevin Buettner <kevinb@redhat.com>

4 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

unordered_map.h

gdbsupport: add gdb::unordered_string_map It occurred to me that when we use a gdb::unordered_map<std::string, T> we construct a temporary std::string for each lookup from a `const char *`, possibly doing dynamic allocation. This is really unnecessary, because it's easy to compare an existing `const char *` (or std::string_view) with an std::string. This can therefore be avoided by having transparent hash and eq types. Because this is a common enough case, add it to gdbsupport/unordered_map.h, so it can easily be reused. Define the gdb::unordered_string_map type, which uses hash and eq types that work on std::string_view. Both `const char *` and `std::string` can implicitly be converted to std::string_view, so this should be sufficient. Change-Id: Id93448d831696d25472f13c15212f13712ad8492 Approved-by: Kevin Buettner <kevinb@redhat.com>

5 months ago

unordered_set.h

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

Update copyright dates to include 2026 This updates the copyright headers to include 2026. I did this by running gdb/copyright.py and then manually modifying a few files as noted by the script.

6 months ago

README

This is a helper library that is used by gdb and gdbserver.

To send patches, follow the gdb patch submission instructions in
../gdb/CONTRIBUTE.  For maintainers, see ../gdb/MAINTAINERS.