luke-ui/packages/@luke-ui/react/src/theme/__fixtures__/v2-goldens/ at main · lukebennett.dev/luke-ui · Tangled

lukebennett.dev / luke-ui

0

[READ-ONLY] Mirror of https://github.com/lukebennett88/luke-ui. luke-ui.netlify.app/

0

luke-ui / packages / @luke-ui / react / src / theme / __fixtures__ / v2-goldens /

at main 2 files

Luke Bennett Share duplicated recipe styles, tokenise disabled fade and tap target (#258) (#338) 6hrs ago

Share duplicated recipe styles, tokenise disabled fade and tap target (#258) (#338) * Share duplicated recipe styles and tokenise disabled fade and tap target (#258) * Move the focus ring into the reset default, per-recipe only when deviating Buttons, links, and combobox actions now inherit the default ring from the reset layer (which also matches React Aria's deterministic [data-focus-visible] signal), instead of restating it in each recipe. Recipes keep a ring only where the default cannot apply: :focus-within on input groups and combobox fields, and the checkbox's non-focusable indicator box. Removing the recipes' transparent resting outline also drops the spurious always-on ring that forced-colors mode was painting around every control — the forced-colors focus ring still comes from the reset's Highlight rule. * Fix double checkbox focus ring and tokenise combobox action sizing Checkbox: the reset default ring matched the clickable content carrying [data-focus-visible], painting a second outline around the whole row on top of the indicator box's ring. The content now opts out with outline: none, so keyboard focus outlines only the indicator box. A browser test pins the contract: content has no outline while the indicator shows the solid 2px ring. Combobox: the medium trigger and clear-button actions stayed hardcoded at 28px after the sizing tokens landed. They now size from a new semantic controlSize.comboboxAction token (28px in both themes), so the action geometry flows from the theme contract instead of a recipe-local literal and tracks control-size changes.

6 hours ago

Share duplicated recipe styles, tokenise disabled fade and tap target (#258) (#338) * Share duplicated recipe styles and tokenise disabled fade and tap target (#258) * Move the focus ring into the reset default, per-recipe only when deviating Buttons, links, and combobox actions now inherit the default ring from the reset layer (which also matches React Aria's deterministic [data-focus-visible] signal), instead of restating it in each recipe. Recipes keep a ring only where the default cannot apply: :focus-within on input groups and combobox fields, and the checkbox's non-focusable indicator box. Removing the recipes' transparent resting outline also drops the spurious always-on ring that forced-colors mode was painting around every control — the forced-colors focus ring still comes from the reset's Highlight rule. * Fix double checkbox focus ring and tokenise combobox action sizing Checkbox: the reset default ring matched the clickable content carrying [data-focus-visible], painting a second outline around the whole row on top of the indicator box's ring. The content now opts out with outline: none, so keyboard focus outlines only the indicator box. A browser test pins the contract: content has no outline while the indicator shows the solid 2px ring. Combobox: the medium trigger and clear-button actions stayed hardcoded at 28px after the sizing tokens landed. They now size from a new semantic controlSize.comboboxAction token (28px in both themes), so the action geometry flows from the theme contract instead of a recipe-local literal and tracks control-size changes.

6 hours ago