alpha
Login
or
Join now
lukebennett.dev
/
luke-ui
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
[READ-ONLY] Mirror of https://github.com/lukebennett88/luke-ui.
luke-ui.netlify.app/
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
Overview
Issues
Pulls
Pipelines
luke-ui
/
packages
/
@luke-ui
/
react
/
src
/
text
/
at
main
3 files
Luke Bennett
Fix the axe violations in three stories (#313)
1d ago
d4cd3a6a
index.tsx
Add typography components for blockquote, code, em, kbd, quote, and strong (#287) * Add new typography components * Update docs
2 days ago
text.stories.tsx
Fix the axe violations in three stories (#313) Groundwork for gating story tests on axe (#94). Flipping parameters.a11y.test to 'error' fails 7 of 112 stories across four rules; this fixes three of them. Text's middle-truncation helper put aria-label on a role-less div, which ARIA prohibits. The full identifier now reaches assistive technology through VisuallyHidden instead, alongside the aria-hidden visual spans. IconButton's AllIcons story rendered a button per icon with no accessible name. Each now carries a label derived from its icon name. Combobox's Size and Validation stories ended with a popover still open, so react-aria's aria-hide-outside left focusable elements under aria-hidden when axe ran. Both now close it and assert the listbox is gone. Validation opened one without asking: native constraint validation focuses the invalid input, and menuTrigger defaults to 'focus'. Driving the story in a browser confirms a real user never meets the mismatch — the next Tab or Escape closes the popover and unhides the page in the same interaction — so this is a story artifact, not a component defect. The flag stays 'todo': the remaining colour-contrast failures are not resolved yet.
1 day ago
text.visual.test.tsx
Migrate typography to theme type roles (#116) * Migrate typography to composite type roles * Address typography review feedback
2 weeks ago