alpha
Login
or
Join now
lukebennett.dev
/
luke-ui
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
[READ-ONLY] Mirror of https://github.com/lukebennett88/luke-ui.
luke-ui.netlify.app/
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
Overview
Issues
Pulls
Pipelines
luke-ui
/
packages
/
@luke-ui
/
react
/
src
/
button
/
at
main
1 folder
4 files
Luke Bennett
Shrink button icons to 16px at both sizes (#308)
7hrs ago
bc3fdd1e
primitive
Shrink button icons to 16px at both sizes (#308) * Shrink button icons to 16px at both sizes The medium button provided its nested icons and spinner a 24px icon size, which read as oversized against the 40px control and left the icon larger than the pending spinner IconButton already drew at 16px. Both button sizes now take a 16px icon, so the size-to-icon lookup table collapses to a single constant. * Show the flat icon size in the button docs examples The size example was label-only, so nothing in the docs showed that the icon holds at 16px while the control grows. Give both sizes a start icon. Drop the explicit aria-hidden from the icons example: Icon already defaults it to true when no title is set, so the prop taught readers a step they can skip.
7 hours ago
button.browser.test.tsx
Shrink button icons to 16px at both sizes (#308) * Shrink button icons to 16px at both sizes The medium button provided its nested icons and spinner a 24px icon size, which read as oversized against the 40px control and left the icon larger than the pending spinner IconButton already drew at 16px. Both button sizes now take a 16px icon, so the size-to-icon lookup table collapses to a single constant. * Show the flat icon size in the button docs examples The size example was label-only, so nothing in the docs showed that the icon holds at 16px while the control grows. Give both sizes a start icon. Drop the explicit aria-hidden from the icons example: Icon already defaults it to true when no title is set, so the prop taught readers a step they can skip.
7 hours ago
button.stories.tsx
Simplify LoadingSpinner around a children loading API (#195) * Simplify LoadingSpinner around a children loading API * Rename loading prop to isLoading for consistency across components * Refactor LoadingSpinner to use slotted recipe architecture * Add VisuallyHidden component * Switch from render to elementType * Use WCAG clip technique for visually-hidden styles Replace clip-path: circle(0) with the WCAG-standard clip technique (1px clipped box, overflow hidden, white-space nowrap) in both the visuallyHidden recipe and Text's isVisuallyHidden variant. circle(0) left a full-size layout box (overflow risk) and has questionable Safari focus-ring support. * Share visually-hidden style between recipe and Text variant
1 week ago
button.visual.test.tsx
Complete visual-system conformance coverage (#121)
2 weeks ago
index.tsx
Rebuild styling entrypoints and add Box (#119)
2 weeks ago