luke-ui/packages/@luke-ui/react/src/combobox-field/ at dialog · lukebennett.dev/luke-ui · Tangled

lukebennett.dev / luke-ui

0

[READ-ONLY] Mirror of https://github.com/lukebennett88/luke-ui. luke-ui.netlify.app/

0

luke-ui / packages / @luke-ui / react / src / combobox-field /

at dialog 1 folder 4 files

Luke Bennett Bypass internal barrel imports and guard against new barrels (#196) 15d ago

Rebuild styling entrypoints and add Box (#119)

2 weeks ago

combobox-field.browser.test.tsx

Bypass internal barrel imports and guard against new barrels (#196) Adds unbarrelify as a dev tool (catalog + @luke-ui/react devDependency) and rewires the five internal consumers that imported through src/styles/index.ts and src/combobox-field/primitive/index.tsx to import directly from utilities.css.js and item.js instead. Neither barrel file is deleted: both back public subpath exports (./styles and ./combobox-field/primitive). Because those exports point at built dist/ paths rather than the src/ files themselves, unbarrelify's built-in package-export exception does not recognise them and would delete both as internal barrels, which breaks the public API (confirmed via a failing tsc run and vp pack silently dropping both exports entries). check:barrels therefore skips these two known package-export barrels; every other barrel in the source tree is still caught, verified with a throwaway negative test. Wires check:barrels ("unbarrelify --check") into turbo.json's aggregate check task the same way check:format/check:lint/check:types are wired, as its own global task that no-ops for packages without the script, so `pnpm run check` exercises it repo-wide. pnpm-lock.yaml picks up unrelated transitive churn (mostly optional oxc-transform/oxc-minify platform binaries no longer needed after a srvx bump) that surfaced when the lockfile was re-resolved for the new dependency; build and tests pass against the regenerated lockfile.

2 weeks ago

combobox-field.stories.tsx

Migrate Combobox to the new theme (#114) * Migrate Combobox to the new theme * Address Combobox review feedback * Polish combobox theme previews * Fix Combobox option hover contrast

2 weeks ago

combobox-field.visual.test.tsx

Bypass internal barrel imports and guard against new barrels (#196) Adds unbarrelify as a dev tool (catalog + @luke-ui/react devDependency) and rewires the five internal consumers that imported through src/styles/index.ts and src/combobox-field/primitive/index.tsx to import directly from utilities.css.js and item.js instead. Neither barrel file is deleted: both back public subpath exports (./styles and ./combobox-field/primitive). Because those exports point at built dist/ paths rather than the src/ files themselves, unbarrelify's built-in package-export exception does not recognise them and would delete both as internal barrels, which breaks the public API (confirmed via a failing tsc run and vp pack silently dropping both exports entries). check:barrels therefore skips these two known package-export barrels; every other barrel in the source tree is still caught, verified with a throwaway negative test. Wires check:barrels ("unbarrelify --check") into turbo.json's aggregate check task the same way check:format/check:lint/check:types are wired, as its own global task that no-ops for packages without the script, so `pnpm run check` exercises it repo-wide. pnpm-lock.yaml picks up unrelated transitive churn (mostly optional oxc-transform/oxc-minify platform binaries no longer needed after a srvx bump) that surfaced when the lockfile was re-resolved for the new dependency; build and tests pass against the regenerated lockfile.

2 weeks ago

Rebuild styling entrypoints and add Box (#119)

2 weeks ago