kleidos/test/states/ at main · jmrp.io/kleidos · Tangled

jmrp.io / kleidos

0

[READ-ONLY] Mirror of https://github.com/jmrplens/kleidos. Kleidos — Hardware BLE password manager for ESP32-S3 (M5StickC Plus2, StickS3, M5Stack Gray, T-Deck, Cardputer) jmrplens.github.io/kleidos/

0

kleidos / test / states /

at main 9 folders

José M. Requena Plens test(states): cover out-of-phase and mismatch branches in wizard logic 7d ago

test_ble_state_lifecycle

test(states): cover out-of-phase and mismatch branches in wizard logic Add out-of-phase no-op guards and null/oversize/mismatch branches for the change-pin, credential-detail, and onboarding state machines, driving their pure boolean decision points to near-full branch coverage. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_change_pin_logic

test(states): cover out-of-phase and mismatch branches in wizard logic Add out-of-phase no-op guards and null/oversize/mismatch branches for the change-pin, credential-detail, and onboarding state machines, driving their pure boolean decision points to near-full branch coverage. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_cred_detail_logic

test(states): cover out-of-phase and mismatch branches in wizard logic Add out-of-phase no-op guards and null/oversize/mismatch branches for the change-pin, credential-detail, and onboarding state machines, driving their pure boolean decision points to near-full branch coverage. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_home_state

Rename VaultStateHandler to HomeStateHandler (home_state, AppState::Home) The FSM state handler was misnamed — "vault" belongs to the storage/crypto layer (src/vault/, VaultStore, VaultCrypto), whereas this handler is the post-unlock home orchestrator (menu + settings + admin + device config + BLE hosts + cred-detail). Rename it throughout: class VaultStateHandler -> HomeStateHandler; files src/states/vault_state.{h,cpp} -> home_state.{h,cpp} (+ the mirror test test_vault_state -> test_home_state); enum AppState::VaultMenu -> AppState::Home; the debug screen-name strings "VAULT_MENU/..." -> "HOME/..."; the appStateName() label "VAULT_MENU" -> "HOME"; the "requires VAULT_MENU" debug messages; and the FSM references in the docs, .github skills/agents, and QA scripts. The GOTO debug command keeps "VAULT_MENU" as a back-compat alias alongside the new "HOME". The src/vault/ storage/crypto layer keeps "vault" (correct usage); the VaultMenuView / vault_row_widgets / cred_row_cache helpers keep their names (they name the vault-contents menu, still accurate). Pure rename, no logic change. Verified: native 1168/1168, pio check clean, guards, full fleet -Werror (9 variants + debug), and on-device QA on Stick S3 + M5Stack Gray (boot, PIN dial via PinEntryRenderer, home menu nav, HOME/... state strings). Completes the vault-state god-object split: HomeStateHandler is device-agnostic and ~30 methods / ~16 fields, under the Sonar S1448/S1820 thresholds. Claude-Session: https://claude.ai/code/session_01Y7Cy1HetRp6TZAUAeekN8X

2 weeks ago

test_onboarding_logic

test(states): cover out-of-phase and mismatch branches in wizard logic Add out-of-phase no-op guards and null/oversize/mismatch branches for the change-pin, credential-detail, and onboarding state machines, driving their pure boolean decision points to near-full branch coverage. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_set_clock_commit

Add display-only ClockSource record (NVS) and surface it in RTC? Record WHO set the clock last (Manual / WebAdmin / Gps; u8 clk_src in the kleidos NVS namespace) so the console and diagnostics can show the provenance of the running time. The two existing writers now tag themselves: the set-clock commit records Manual and the admin portal's time-sync handler records WebAdmin; the GPS writer lands with the sync task. RTC? appends src= as the LAST field on both the ok=0 and ok=1 lines so existing field-parsing HIL assertions stay valid. SECURITY: the tag is write-and-display only — it is never read by rtc::internal::evaluateTrust, rtc::clockTrust or brute_force_guard (grep-verified), and the running trust after any sync stays Volatile. The shared native NvsStore fake (test/support/fake_storage.h) grows from a no-op into a functional in-memory u8 model with a raw corruption seam, reset alongside the filesystem model; the set-clock commit suite's spy becomes per-key so both the tz_idx write and the Manual tag are assertable in one commit. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_settings_nav_logic

Add "GPS time sync" settings action and progress overlay (HAS_GPS boards) Settings -> Device gains a one-shot "GPS time sync" row on HAS_GPS boards (DEVICE reaches exactly kSettingsMaxItems there; GPS-less boards keep the 4-item layout with RESTART last). Selecting it opens GpsSyncController, a thin overlay over the gps:: sync engine: it polls syncPoll, refreshes the elapsed/timeout countdown once per second, and closes on fix (success toast), timeout acknowledgement, or cancel (B-long on button boards, Esc on keyboard boards). Every UI exit path — including overlay idle-sleep and the parent reset — funnels through reset(), whose syncCancel powers the receiver down. The trailing settings value surfaces the last clock-set provenance (ClockSource). Long-press edges are polled before short-click polls on the same button, matching the documented ButtonInput call order. Carried polish: the UART facade begin() now releases the TX/RX pads on its partial-failure branch, syncCancel documents the Core-1 owning-task contract, and the stale SyncPhase::Idle doc phrase is reworded. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago

test_totp_epoch

Harden the time core: atomic setDateTime, cached trust reads, UTC-exact TOTP epoch - F1: totp_epoch.h converts the RTC reading with the exact UTC civil-calendar converter (rtc::internal::dateTimeToEpoch) instead of local-time mktime; the native suite now pins hard-coded UTC vectors (1767225600 / 1783472461) so a local-time regression fails under a non-UTC host TZ instead of cancelling out. - F2: add rtc::setDateTime (one applyEpoch on the internal backend; one 7-byte I2C burst over regs 0x02..0x08 on the BM8563 via new IRtc::writeDateTime) and use it in setClockCommit and the admin portal handleSetTime (gmtime_r path removed). - F3: cache the NVS seed floor (internal) and the VL/integrity verdict (BM8563, ~1 s TTL via millis32, invalidated by every time write) so clockTrust() no longer opens an NVS handle / hits the I2C bus per UI frame; caches are atomics and never change what is returned. - F4: getValidTime reads through new rtc::getDateTime — one gettimeofday (internal) / one latched burst read (BM8563) — so date and time can no longer straddle a midnight rollover. - F5: correct the audit-log timestamp docs (UTC, not local; any trusted clock, not only BM8563) and refresh rtc-internal.md. Native 1626/1626; sticks3/gray/plus2/coreink debug builds clean under -Werror; variant/conditional/layout guards, doxygen and pio check green. Claude-Session: https://claude.ai/code/session_01U878bNJtg9bCvAMM8CFKqS

1 week ago

test_two_button_nav

Fix set-clock button polling order so long presses survive on hardware SetClockController::update polled the short-click edges before the long-press edges. GpioButtonInput::wasClicked() is wasReleased() and consumes ANY release edge, so on physical buttons every A release (including a long hold's) was misread as an increment: field advance, commit, and B-long cancel were unreachable on all button boards. Poll activateLong/backLong before downShort/upShort (else-if on the same button), the documented ButtonInput call order already followed by stick_vault_view and cred_detail_controller. Add native regression tests pinning the order contract against a GPIO-semantics fake, which VirtualButtonInput's hold-gated wasClicked() cannot capture. Claude-Session: https://claude.ai/code/session_01SV58JXhfxhhc9DC6vdjBo4

1 week ago