kleidos/src/ui/input/ at main · jmrp.io/kleidos · Tangled

jmrp.io / kleidos

0

[READ-ONLY] Mirror of https://github.com/jmrplens/kleidos. Kleidos — Hardware BLE password manager for ESP32-S3 (M5StickC Plus2, StickS3, M5Stack Gray, T-Deck, Cardputer) jmrplens.github.io/kleidos/

0

kleidos / src / ui / input /

at main 7 files

José M. Requena Plens Fix ui entry/input/render/widgets/debug quality findings 2w ago

Fix ui entry/input/render/widgets/debug quality findings pin_entry_ui: use auto for redundant int16_t decls, make drawStickDial const, and drop the redundant private specifier. virtual_button_input: annotate the setState override. aa_shapes: extract the gauge wedge blend into a helper to cut nesting and cognitive complexity, and use auto for a redundant decl. debug_console: move the two trailing includes to the top include block. device_panel/on_device_menu: drop NOSONAR suppressions for the variant-gated S5817 false positives (left OPEN for owner review; a plain rationale comment replaces the suppression). Fixes S5827/S5817/S3539/S3471/S3776/S134/S954. Leaves S5817 (input-gated), S4144 (identical default virtual stubs), S1448/S1820 (class split) OPEN. Claude-Session: https://claude.ai/code/session_01Y7Cy1HetRp6TZAUAeekN8X

2 weeks ago

generic_keyboard_button_input.h

docs: fix Doxygen doc-lint errors (74 -> 0) Clear all pre-existing doc-lint failures so the API-docs gate passes: - Add @param/@return to documented members that were missing them (Inplace{Vector,String,Queue,Function} accessors and constructors, app_runtime FSM seams, debug_console::handleCmd, button setState, TDeckTouch::injectDrag). - Fix unresolvable \ref commands: drop the stray trailing colon that the parser swallowed into the target, qualify namespace-scope references in @file blocks, and downgrade ambiguous unqualified member references (names shared across containers) and overload-by-signature references to @c code spans. Comment-only; no functional change. Verified with doxygen 1.17.0 (the CI pin): doxygen Doxyfile exits 0.

1 month ago

gpio_button_input.h

docs: fix Doxygen doc-lint errors (74 -> 0) Clear all pre-existing doc-lint failures so the API-docs gate passes: - Add @param/@return to documented members that were missing them (Inplace{Vector,String,Queue,Function} accessors and constructors, app_runtime FSM seams, debug_console::handleCmd, button setState, TDeckTouch::injectDrag). - Fix unresolvable \ref commands: drop the stray trailing colon that the parser swallowed into the target, qualify namespace-scope references in @file blocks, and downgrade ambiguous unqualified member references (names shared across containers) and overload-by-signature references to @c code spans. Comment-only; no functional change. Verified with doxygen 1.17.0 (the CI pin): doxygen Doxyfile exits 0.

1 month ago

hold_button.cpp

refactor(ui): route the last 4 direct display:: draws through ui::Canvas Close out the display::->ui::Canvas migration so all app/UI rendering goes through the library: - hold_button: hold-progress bar fillRects -> RasterCanvas.fillRect (incremental overlay, kept frameless on purpose). - pin_entry_ui: 3-button digit drawStringBuffered -> a one-screen canvas frame (frameBegin/fillRect(bg)/drawText/frameCommit) for the same atomic flicker-free push on boards with a live shadow framebuffer. Font role traced to Font::LARGE; old size=6 mapped to drawText scale (flagged jaggy for the font-resampling chunk). - admin_state: display::qrcode -> canvas-drawn finder-pattern placeholder (STOPGAP, mirrors graphics::drawQrPlaceholder) pending the real QR encoder component. Zero display:: draw primitives remain under src/states + src/ui outside the documented exceptions (render/, text_renderer, aa_shapes, hw_test_state, debug_*).

1 month ago

Retire LVGL entirely (HAS_LVGL gone) The T-Deck was the only LVGL device and now renders through the in-house UI library (verified on hardware), so every #if HAS_LVGL branch is dead. Remove the framework wholesale: - Delete src/ui/lvgl/ (25 files: hal, input, screen_manager, theme, demo, brand_mark, and the per-screen lvgl_*_screen set) and src/ui/popup/lvgl_popup_adapter.{cpp,h}. - Delete src/ui/core/render_task.{cpp,h} (the lv_timer_handler worker + LVGL recursive mutex; every caller was LVGL-gated) and variants/tdeck/lv_conf.h. - Delete src/hal/common/display_hal_tft.cpp (the HAS_LVGL && ST7789 backend); the T-Deck now links display_hal_m5.cpp (BL pin >= 0, identical brightness path). - De-gate ~25 source files: drop the dead HAS_LVGL branch, keep the live in-house / HAS_KEYBOARD branch. - Remove the HAS_LVGL macro (variants/tdeck/variant.h and the platform_defaults.h default) and the lvgl/lvgl @ 9.2.2 lib_dep + LV_CONF flag in tdeck.ini. - Update docs (groups.dox, building, ui/, design-system) and CLAUDE.md / copilot-instructions to reflect that LVGL is retired fleet-wide. Font tooling (scripts/fonts lv_font_conv) and descriptive lineage comments (e.g. "raster replacement for lv_textarea") are kept. Full fleet builds green; native 1075/1075; pio check clean; no HAS_LVGL/lvgl runtime reference remains.

4 weeks ago

virtual_button_input.cpp

Document ui/ per style guide (§17/§18)

1 month ago

virtual_button_input.h

Fix ui entry/input/render/widgets/debug quality findings pin_entry_ui: use auto for redundant int16_t decls, make drawStickDial const, and drop the redundant private specifier. virtual_button_input: annotate the setState override. aa_shapes: extract the gauge wedge blend into a helper to cut nesting and cognitive complexity, and use auto for a redundant decl. debug_console: move the two trailing includes to the top include block. device_panel/on_device_menu: drop NOSONAR suppressions for the variant-gated S5817 false positives (left OPEN for owner review; a plain rationale comment replaces the suppression). Fixes S5827/S5817/S3539/S3471/S3776/S134/S954. Leaves S5817 (input-gated), S4144 (identical default virtual stubs), S1448/S1820 (class split) OPEN. Claude-Session: https://claude.ai/code/session_01Y7Cy1HetRp6TZAUAeekN8X

2 weeks ago