+1 -1

.forge/commands/pr_description.md commands/github-pr-description.md

Reviewed

··· 1 1 --- 2 2 - name: pr-description 2 2 + name: github-pr-description 3 3 description: Updates the description of the PR 4 4 --- 5 5

.forge/skills/pr-description/SKILL.md crates/forge_repo/src/skills/pr-description/SKILL.md

Reviewed

+17 -1

crates/forge_repo/src/skill.rs

Reviewed

··· 52 52 "forge://skills/execute-plan/SKILL.md", 53 53 include_str!("skills/execute-plan/SKILL.md"), 54 54 ), 55 55 + ( 56 56 + "forge://skills/pr-description/SKILL.md", 57 57 + include_str!("skills/pr-description/SKILL.md"), 58 58 + ), 55 59 ]; 56 60 57 61 builtin_skills ··· 334 338 let actual = repo.load_builtin_skills(); 335 339 336 340 // Assert 337 337 - assert_eq!(actual.len(), 2); 341 341 + assert_eq!(actual.len(), 3); 338 342 339 343 // Check create-skill 340 344 let create_skill = actual.iter().find(|s| s.name == "create-skill").unwrap(); ··· 361 365 .contains("Execute structured task plans") 362 366 ); 363 367 assert!(execute_plan.command.contains("Execute Plan")); 368 368 + 369 369 + // Check pr-description 370 370 + let pr_description = actual 371 371 + .iter() 372 372 + .find(|s| s.name == "create-pr-description") 373 373 + .unwrap(); 374 374 + assert_eq!( 375 375 + pr_description.path, 376 376 + Some(std::path::Path::new("forge://skills/pr-description/SKILL.md").to_path_buf()) 377 377 + ); 378 378 + assert!(!pr_description.description.is_empty()); 379 379 + assert!(pr_description.command.contains("Create PR Description")); 364 380 } 365 381 366 382 #[tokio::test]

+33 -2

crates/forge_services/src/command.rs

Reviewed

··· 22 22 pub fn new(infra: Arc<F>) -> Self { 23 23 Self { infra, cache: Default::default() } 24 24 } 25 25 + 26 26 + /// Load built-in commands that are embedded in the application binary. 27 27 + fn init_default(&self) -> anyhow::Result<Vec<Command>> { 28 28 + parse_command_iter( 29 29 + [( 30 30 + "github-pr-description", 31 31 + include_str!("../../../commands/github-pr-description.md"), 32 32 + )] 33 33 + .into_iter() 34 34 + .map(|(name, content)| (name.to_string(), content.to_string())), 35 35 + ) 36 36 + } 25 37 } 26 38 27 39 #[async_trait::async_trait] ··· 42 54 } 43 55 44 56 async fn init(&self) -> anyhow::Result<Vec<Command>> { 45 45 - // Load built-in commands 46 46 - let mut commands = vec![]; 57 57 + // Load built-in commands first (lowest precedence) 58 58 + let mut commands = self.init_default()?; 47 59 48 60 // Load custom commands from global directory 49 61 let dir = self.infra.get_environment().command_path(); ··· 192 204 assert!(!command.description.is_empty()); 193 205 assert!(command.prompt.is_some()); 194 206 } 207 207 + } 208 208 + 209 209 + #[test] 210 210 + fn test_init_default_contains_builtin_commands() { 211 211 + // Fixture 212 212 + let service = CommandLoaderService::<()> { infra: Arc::new(()), cache: Default::default() }; 213 213 + 214 214 + // Execute 215 215 + let actual = service.init_default().unwrap(); 216 216 + 217 217 + // Verify github-pr-description 218 218 + let command = actual 219 219 + .iter() 220 220 + .find(|c| c.name.as_str() == "github-pr-description") 221 221 + .expect("github-pr-description should be a built-in command"); 222 222 + 223 223 + assert_eq!(command.name.as_str(), "github-pr-description"); 224 224 + assert!(!command.description.is_empty()); 225 225 + assert!(command.prompt.is_some()); 195 226 } 196 227 197 228 #[test]