+7 -7

Cargo.lock

Reviewed

··· 992 992 993 993 [[package]] 994 994 name = "clap" 995 995 - version = "4.5.48" 995 995 + version = "4.5.56" 996 996 source = "registry+https://github.com/rust-lang/crates.io-index" 997 997 - checksum = "e2134bb3ea021b78629caa971416385309e0131b351b25e01dc16fb54e1b5fae" 997 997 + checksum = "a75ca66430e33a14957acc24c5077b503e7d374151b2b4b3a10c83b4ceb4be0e" 998 998 dependencies = [ 999 999 "clap_builder", 1000 1000 "clap_derive", ··· 1002 1002 1003 1003 [[package]] 1004 1004 name = "clap_builder" 1005 1005 - version = "4.5.48" 1005 1005 + version = "4.5.56" 1006 1006 source = "registry+https://github.com/rust-lang/crates.io-index" 1007 1007 - checksum = "c2ba64afa3c0a6df7fa517765e31314e983f51dda798ffba27b988194fb65dc9" 1007 1007 + checksum = "793207c7fa6300a0608d1080b858e5fdbe713cdc1c8db9fb17777d8a13e63df0" 1008 1008 dependencies = [ 1009 1009 "anstream", 1010 1010 "anstyle", ··· 1014 1014 1015 1015 [[package]] 1016 1016 name = "clap_derive" 1017 1017 - version = "4.5.47" 1017 1017 + version = "4.5.55" 1018 1018 source = "registry+https://github.com/rust-lang/crates.io-index" 1019 1019 - checksum = "bbfd7eae0b0f1a6e63d4b13c9c478de77c2eb546fba158ad50b4203dc24b9f9c" 1019 1019 + checksum = "a92793da1a46a5f2a02a6f4c46c6496b28c43638adea8306fcb0caa1634f24e5" 1020 1020 dependencies = [ 1021 1021 "heck", 1022 1022 "proc-macro2", ··· 1375 1375 checksum = "18e4fdb82bd54a12e42fb58a800dcae6b9e13982238ce2296dc3570b92148e1f" 1376 1376 dependencies = [ 1377 1377 "data-encoding", 1378 1378 - "syn 1.0.109", 1378 1378 + "syn 2.0.106", 1379 1379 ] 1380 1380 1381 1381 [[package]]

+3

Cargo.toml

Reviewed

··· 13 13 "pocket", 14 14 "reflector", 15 15 ] 16 16 + 17 17 + [workspace.dependencies] 18 18 + clap = { version = "4.5.56", features = ["derive", "env"] }

+1 -1

constellation/Cargo.toml

Reviewed

··· 11 11 axum-extra = { version = "0.10.0", features = ["query", "typed-header"] } 12 12 axum-metrics = "0.2" 13 13 bincode = "1.3.3" 14 14 - clap = { version = "4.5.26", features = ["derive"] } 14 14 + clap = { workspace = true } 15 15 ctrlc = "3.4.5" 16 16 flume = { version = "0.11.1", default-features = false } 17 17 fs4 = { version = "0.12.0", features = ["sync"] }

+47 -48

constellation/src/bin/main.rs

Reviewed

··· 26 26 #[arg(long)] 27 27 #[clap(default_value = "0.0.0.0:6789")] 28 28 bind: SocketAddr, 29 29 - /// optionally disable the metrics server 30 30 - #[arg(long)] 31 31 - #[clap(default_value_t = false)] 29 29 + /// enable metrics collection and serving 30 30 + #[arg(long, action)] 32 31 collect_metrics: bool, 33 32 /// metrics server's listen address 34 34 - #[arg(long)] 33 33 + #[arg(long, requires("collect_metrics"))] 35 34 #[clap(default_value = "0.0.0.0:8765")] 36 35 bind_metrics: SocketAddr, 37 36 /// Jetstream server to connect to (exclusive with --fixture). Provide either a wss:// URL, or a shorhand value: ··· 222 221 // only spawn monitoring thread if the metrics server is running 223 222 if collect_metrics { 224 223 s.spawn(move || { // monitor thread 225 225 - let stay_alive = stay_alive.clone(); 226 226 - let check_alive = stay_alive.clone(); 227 227 - 228 228 - let process_collector = metrics_process::Collector::default(); 229 229 - process_collector.describe(); 230 230 - metrics::describe_gauge!( 231 231 - "storage_available", 232 232 - metrics::Unit::Bytes, 233 233 - "available to be allocated" 234 234 - ); 235 235 - metrics::describe_gauge!( 236 236 - "storage_free", 237 237 - metrics::Unit::Bytes, 238 238 - "unused bytes in filesystem" 239 239 - ); 240 240 - if let Some(ref p) = data_dir { 241 241 - if let Err(e) = fs4::available_space(p) { 242 242 - eprintln!("fs4 failed to get available space. may not be supported here? space metrics may be absent. e: {e:?}"); 243 243 - } else { 244 244 - println!("disk space monitoring should work, watching at {p:?}"); 245 245 - } 246 246 - } 224 224 + let stay_alive = stay_alive.clone(); 225 225 + let check_alive = stay_alive.clone(); 247 226 248 248 - 'monitor: loop { 249 249 - match readable.get_stats() { 250 250 - Ok(StorageStats { dids, targetables, linking_records, .. }) => { 251 251 - metrics::gauge!("storage.stats.dids").set(dids as f64); 252 252 - metrics::gauge!("storage.stats.targetables").set(targetables as f64); 253 253 - metrics::gauge!("storage.stats.linking_records").set(linking_records as f64); 227 227 + let process_collector = metrics_process::Collector::default(); 228 228 + process_collector.describe(); 229 229 + metrics::describe_gauge!( 230 230 + "storage_available", 231 231 + metrics::Unit::Bytes, 232 232 + "available to be allocated" 233 233 + ); 234 234 + metrics::describe_gauge!( 235 235 + "storage_free", 236 236 + metrics::Unit::Bytes, 237 237 + "unused bytes in filesystem" 238 238 + ); 239 239 + if let Some(ref p) = data_dir { 240 240 + if let Err(e) = fs4::available_space(p) { 241 241 + eprintln!("fs4 failed to get available space. may not be supported here? space metrics may be absent. e: {e:?}"); 242 242 + } else { 243 243 + println!("disk space monitoring should work, watching at {p:?}"); 254 244 } 255 255 - Err(e) => eprintln!("failed to get stats: {e:?}"), 256 245 } 257 246 258 258 - process_collector.collect(); 259 259 - if let Some(ref p) = data_dir { 260 260 - if let Ok(avail) = fs4::available_space(p) { 261 261 - metrics::gauge!("storage.available").set(avail as f64); 247 247 + 'monitor: loop { 248 248 + match readable.get_stats() { 249 249 + Ok(StorageStats { dids, targetables, linking_records, .. }) => { 250 250 + metrics::gauge!("storage.stats.dids").set(dids as f64); 251 251 + metrics::gauge!("storage.stats.targetables").set(targetables as f64); 252 252 + metrics::gauge!("storage.stats.linking_records").set(linking_records as f64); 253 253 + } 254 254 + Err(e) => eprintln!("failed to get stats: {e:?}"), 262 255 } 263 263 - if let Ok(free) = fs4::free_space(p) { 264 264 - metrics::gauge!("storage.free").set(free as f64); 256 256 + 257 257 + process_collector.collect(); 258 258 + if let Some(ref p) = data_dir { 259 259 + if let Ok(avail) = fs4::available_space(p) { 260 260 + metrics::gauge!("storage.available").set(avail as f64); 261 261 + } 262 262 + if let Ok(free) = fs4::free_space(p) { 263 263 + metrics::gauge!("storage.free").set(free as f64); 264 264 + } 265 265 } 266 266 - } 267 267 - let wait = time::Instant::now(); 268 268 - while wait.elapsed() < MONITOR_INTERVAL { 269 269 - thread::sleep(time::Duration::from_millis(100)); 270 270 - if check_alive.is_cancelled() { 271 271 - break 'monitor 266 266 + let wait = time::Instant::now(); 267 267 + while wait.elapsed() < MONITOR_INTERVAL { 268 268 + thread::sleep(time::Duration::from_millis(100)); 269 269 + if check_alive.is_cancelled() { 270 270 + break 'monitor 271 271 + } 272 272 } 273 273 } 274 274 - } 275 275 - stay_alive.drop_guard(); 276 276 - }); 274 274 + stay_alive.drop_guard(); 275 275 + }); 277 276 } 278 277 }); 279 278

+1 -1

pocket/Cargo.toml

Reviewed

··· 5 5 6 6 [dependencies] 7 7 atrium-crypto = "0.1.2" 8 8 - clap = { version = "4.5.41", features = ["derive"] } 8 8 + clap = { workspace = true } 9 9 jwt-compact = { git = "https://github.com/fatfingers23/jwt-compact.git", features = ["es256k"] } 10 10 log = "0.4.27" 11 11 poem = { version = "3.1.12", features = ["acme", "static-files"] }

+1 -1

quasar/Cargo.toml

Reviewed

··· 4 4 edition = "2024" 5 5 6 6 [dependencies] 7 7 - clap = { version = "4.5.46", features = ["derive"] } 7 7 + clap = { workspace = true } 8 8 fjall = "2.11.2"

+1 -1

reflector/Cargo.toml

Reviewed

··· 4 4 edition = "2024" 5 5 6 6 [dependencies] 7 7 - clap = { version = "4.5.47", features = ["derive"] } 7 7 + clap = { workspace = true } 8 8 log = "0.4.28" 9 9 poem = "3.1.12" 10 10 serde = { version = "1.0.219", features = ["derive"] }

+1 -1

slingshot/Cargo.toml

Reviewed

··· 8 8 atrium-common = { git = "https://github.com/uniphil/atrium.git", branch = "fix/resolve-handle-https-accept-whitespace" } 9 9 atrium-identity = { git = "https://github.com/uniphil/atrium.git", branch = "fix/resolve-handle-https-accept-whitespace" } 10 10 atrium-oauth = { git = "https://github.com/uniphil/atrium.git", branch = "fix/resolve-handle-https-accept-whitespace" } 11 11 - clap = { version = "4.5.41", features = ["derive"] } 11 11 + clap = { workspace = true } 12 12 ctrlc = "3.4.7" 13 13 foyer = { version = "0.18.0", features = ["serde"] } 14 14 hickory-resolver = "0.25.2"

+44 -22

slingshot/src/main.rs

Reviewed

··· 15 15 struct Args { 16 16 /// Jetstream server to connect to (exclusive with --fixture). Provide either a wss:// URL, or a shorhand value: 17 17 /// 'us-east-1', 'us-east-2', 'us-west-1', or 'us-west-2' 18 18 - #[arg(long)] 18 18 + #[arg(long, env = "SLINGSHOT_JETSTREAM")] 19 19 jetstream: String, 20 20 /// don't request zstd-compressed jetstream events 21 21 /// 22 22 /// reduces CPU at the expense of more ingress bandwidth 23 23 - #[arg(long, action)] 23 23 + #[arg(long, action, env = "SLINGSHOT_JETSTREAM_NO_ZSTD")] 24 24 jetstream_no_zstd: bool, 25 25 /// where to keep disk caches 26 26 - #[arg(long)] 26 26 + #[arg(long, env = "SLINGSHOT_CACHE_DIR")] 27 27 cache_dir: PathBuf, 28 28 + /// where to listen for incomming requests 29 29 + /// 30 30 + /// cannot be used with acme -- if you need ipv6 see --acme-ipv6 31 31 + #[arg(long, env = "SLINGSHOT_BIND")] 32 32 + #[clap(default_value = "0.0.0.0:8080")] 33 33 + bind: std::net::SocketAddr, 28 34 /// the domain pointing to this server 29 35 /// 30 36 /// if present: 31 37 /// - a did:web document will be served at /.well-known/did.json 32 38 /// - an HTTPS certs will be automatically configured with Acme/letsencrypt 33 39 /// - TODO: a rate-limiter will be installed 34 34 - #[arg(long)] 35 35 - domain: Option<String>, 40 40 + #[arg( 41 41 + long, 42 42 + conflicts_with("bind"), 43 43 + requires("acme_cache_path"), 44 44 + env = "SLINGSHOT_ACME_DOMAIN" 45 45 + )] 46 46 + acme_domain: Option<String>, 36 47 /// email address for letsencrypt contact 37 48 /// 38 49 /// recommended in production, i guess? 39 39 - #[arg(long)] 50 50 + #[arg(long, requires("acme_domain"), env = "SLINGSHOT_ACME_CONTACT")] 40 51 acme_contact: Option<String>, 41 52 /// a location to cache acme https certs 42 53 /// 43 43 - /// only used if --host is specified. omitting requires re-requesting certs 44 44 - /// on every restart, and letsencrypt has rate limits that are easy to hit. 54 54 + /// required when (and only used when) --acme-domain is specified. 45 55 /// 46 56 /// recommended in production, but mind the file permissions. 47 47 - #[arg(long)] 48 48 - certs: Option<PathBuf>, 57 57 + #[arg(long, requires("acme_domain"), env = "SLINGSHOT_ACME_CACHE_PATH")] 58 58 + acme_cache_path: Option<PathBuf>, 59 59 + /// listen for ipv6 when using acme 60 60 + /// 61 61 + /// you must also configure the relevant DNS records for this to work 62 62 + #[arg(long, action, requires("acme_domain"), env = "SLINGSHOT_ACME_IPV6")] 63 63 + acme_ipv6: bool, 49 64 /// an web address to send healtcheck pings to every ~51s or so 50 50 - #[arg(long)] 65 65 + #[arg(long, env = "SLINGSHOT_HEALTHCHECK")] 51 66 healthcheck: Option<String>, 52 52 - /// slingshot server's listen address 53 53 - #[arg(long, default_value = "0.0.0.0:8080")] 54 54 - bind: std::net::SocketAddr, 67 67 + /// enable metrics collection and serving 68 68 + #[arg(long, action, env = "SLINGSHOT_COLLECT_METRICS")] 69 69 + collect_metrics: bool, 55 70 /// metrics server's listen address 56 56 - #[arg(long, default_value = "0.0.0.0:8765")] 71 71 + #[arg(long, requires("collect_metrics"), env = "SLINGSHOT_BIND_METRICS")] 72 72 + #[clap(default_value = "[::]:8765")] 57 73 bind_metrics: std::net::SocketAddr, 58 74 } 59 75 ··· 68 84 69 85 let args = Args::parse(); 70 86 71 71 - if let Err(e) = install_metrics_server(args.bind_metrics) { 72 72 - log::error!("failed to install metrics server: {e:?}"); 73 73 - } else { 74 74 - log::info!("metrics listening at http://{}", args.bind_metrics); 87 87 + if args.collect_metrics { 88 88 + log::trace!("installing metrics server..."); 89 89 + if let Err(e) = install_metrics_server(args.bind_metrics) { 90 90 + log::error!("failed to install metrics server: {e:?}"); 91 91 + } else { 92 92 + log::info!("metrics listening at http://{}", args.bind_metrics); 93 93 + } 75 94 } 76 95 77 96 std::fs::create_dir_all(&args.cache_dir).map_err(|e| { ··· 116 135 server_cache_handle, 117 136 identity, 118 137 repo, 119 119 - args.domain, 138 138 + args.acme_domain, 120 139 args.acme_contact, 121 121 - args.certs, 140 140 + args.acme_cache_path, 141 141 + args.acme_ipv6, 122 142 server_shutdown, 123 143 bind, 124 144 ) ··· 180 200 Ok(()) 181 201 } 182 202 183 183 - fn install_metrics_server(bind_metrics: std::net::SocketAddr) -> Result<(), metrics_exporter_prometheus::BuildError> { 203 203 + fn install_metrics_server( 204 204 + bind_metrics: std::net::SocketAddr, 205 205 + ) -> Result<(), metrics_exporter_prometheus::BuildError> { 184 206 log::info!("installing metrics server..."); 185 207 PrometheusBuilder::new() 186 208 .set_quantiles(&[0.5, 0.9, 0.99, 1.0])?

+9 -7

slingshot/src/server.rs

Reviewed

··· 687 687 make_sync(move |_| doc.clone()) 688 688 } 689 689 690 690 + #[allow(clippy::too_many_arguments)] 690 691 pub async fn serve( 691 692 cache: HybridCache<String, CachedRecord>, 692 693 identity: Identity, 693 694 repo: Repo, 694 694 - domain: Option<String>, 695 695 + acme_domain: Option<String>, 695 696 acme_contact: Option<String>, 696 696 - certs: Option<PathBuf>, 697 697 + acme_cache_path: Option<PathBuf>, 698 698 + acme_ipv6: bool, 697 699 shutdown: CancellationToken, 698 700 bind: std::net::SocketAddr, 699 701 ) -> Result<(), ServerError> { ··· 707 709 "Slingshot", 708 710 env!("CARGO_PKG_VERSION"), 709 711 ) 710 710 - .server(if let Some(ref h) = domain { 712 712 + .server(if let Some(ref h) = acme_domain { 711 713 format!("https://{h}") 712 714 } else { 713 715 "http://localhost:3000".to_string() ··· 728 730 .nest("/openapi", api_service.spec_endpoint()) 729 731 .nest("/xrpc/", api_service); 730 732 731 731 - if let Some(domain) = domain { 733 733 + if let Some(domain) = acme_domain { 732 734 rustls::crypto::aws_lc_rs::default_provider() 733 735 .install_default() 734 736 .expect("alskfjalksdjf"); ··· 741 743 if let Some(contact) = acme_contact { 742 744 auto_cert = auto_cert.contact(contact); 743 745 } 744 744 - if let Some(certs) = certs { 745 745 - auto_cert = auto_cert.cache_path(certs); 746 746 + if let Some(cache_path) = acme_cache_path { 747 747 + auto_cert = auto_cert.cache_path(cache_path); 746 748 } 747 749 let auto_cert = auto_cert.build().map_err(ServerError::AcmeBuildError)?; 748 750 749 751 run( 750 750 - TcpListener::bind("0.0.0.0:443").acme(auto_cert), 752 752 + TcpListener::bind(if acme_ipv6 { "[::]:443" } else { "0.0.0.0:443" }).acme(auto_cert), 751 753 app, 752 754 shutdown, 753 755 )

+1 -1

spacedust/Cargo.toml

Reviewed

··· 5 5 6 6 [dependencies] 7 7 async-trait = "0.1.88" 8 8 - clap = { version = "4.5.40", features = ["derive"] } 8 8 + clap = { workspace = true } 9 9 ctrlc = "3.4.7" 10 10 dropshot = "0.16.2" 11 11 env_logger = "0.11.8"

+18 -8

spacedust/src/main.rs

Reviewed

··· 16 16 struct Args { 17 17 /// Jetstream server to connect to (exclusive with --fixture). Provide either a wss:// URL, or a shorhand value: 18 18 /// 'us-east-1', 'us-east-2', 'us-west-1', or 'us-west-2' 19 19 - #[arg(long)] 19 19 + #[arg(long, env = "SPACEDUST_JETSTREAM")] 20 20 jetstream: String, 21 21 /// don't request zstd-compressed jetstream events 22 22 /// 23 23 /// reduces CPU at the expense of more ingress bandwidth 24 24 - #[arg(long, action)] 24 24 + #[arg(long, action, env = "SPACEDUST_JETSTREAM_NO_ZSTD")] 25 25 jetstream_no_zstd: bool, 26 26 /// spacedust server's listen address 27 27 - #[arg(long, default_value = "0.0.0.0:9998")] 27 27 + #[arg(long, env = "SPACEDUST_BIND")] 28 28 + #[clap(default_value = "[::]:8080")] 28 29 bind: std::net::SocketAddr, 30 30 + /// enable metrics collection and serving 31 31 + #[arg(long, action, env = "SPACEDUST_COLLECT_METRICS")] 32 32 + collect_metrics: bool, 29 33 /// metrics server's listen address 30 30 - #[arg(long, default_value = "0.0.0.0:8765")] 34 34 + #[arg(long, requires("collect_metrics"), env = "SPACEDUST_BIND_METRICS")] 35 35 + #[clap(default_value = "[::]:8765")] 31 36 bind_metrics: std::net::SocketAddr, 32 37 } 33 38 ··· 66 71 67 72 let args = Args::parse(); 68 73 69 69 - if let Err(e) = install_metrics_server(args.bind_metrics) { 70 70 - log::error!("failed to install metrics server: {e:?}"); 71 71 - }; 74 74 + if args.collect_metrics { 75 75 + log::trace!("installing metrics server..."); 76 76 + if let Err(e) = install_metrics_server(args.bind_metrics) { 77 77 + log::error!("failed to install metrics server: {e:?}"); 78 78 + }; 79 79 + } 72 80 73 81 let mut tasks: tokio::task::JoinSet<Result<(), MainTaskError>> = tokio::task::JoinSet::new(); 74 82 ··· 129 137 Ok(()) 130 138 } 131 139 132 132 - fn install_metrics_server(bind_metrics: std::net::SocketAddr) -> Result<(), metrics_exporter_prometheus::BuildError> { 140 140 + fn install_metrics_server( 141 141 + bind_metrics: std::net::SocketAddr, 142 142 + ) -> Result<(), metrics_exporter_prometheus::BuildError> { 133 143 log::info!("installing metrics server..."); 134 144 PrometheusBuilder::new() 135 145 .set_quantiles(&[0.5, 0.9, 0.99, 1.0])?

+1 -1

ufos/Cargo.toml

Reviewed

··· 10 10 bincode = { version = "2.0.1", features = ["serde"] } 11 11 cardinality-estimator-safe = { version = "4.0.2", features = ["with_serde", "with_digest"] } 12 12 chrono = { version = "0.4.41", features = ["serde"] } 13 13 - clap = { version = "4.5.31", features = ["derive"] } 13 13 + clap = { workspace = true } 14 14 dropshot = "0.16.0" 15 15 env_logger = "0.11.7" 16 16 fjall = { git = "https://github.com/fjall-rs/fjall.git", rev = "fb229572bb7d1d6966a596994dc1708e47ec57d8", features = ["lz4"] }

+21 -13

ufos/src/main.rs

Reviewed

··· 26 26 struct Args { 27 27 /// Jetstream server to connect to (exclusive with --fixture). Provide either a wss:// URL, or a shorhand value: 28 28 /// 'us-east-1', 'us-east-2', 'us-west-1', or 'us-west-2' 29 29 - #[arg(long)] 29 29 + #[arg(long, env = "UFOS_JETSTREAM")] 30 30 jetstream: String, 31 31 /// allow changing jetstream endpoints 32 32 - #[arg(long, action)] 32 32 + #[arg(long, action, env = "UFOS_JETSTREAM_FORCE")] 33 33 jetstream_force: bool, 34 34 /// don't request zstd-compressed jetstream events 35 35 /// 36 36 /// reduces CPU at the expense of more ingress bandwidth 37 37 - #[arg(long, action)] 37 37 + #[arg(long, action, env = "UFOS_JETSTREAM_NO_ZSTD")] 38 38 jetstream_no_zstd: bool, 39 39 + /// ufos server's listen address 40 40 + #[arg(long, env = "UFOS_BIND")] 41 41 + #[clap(default_value = "0.0.0.0:9990")] 42 42 + bind: std::net::SocketAddr, 39 43 /// Location to store persist data to disk 40 40 - #[arg(long)] 44 44 + #[arg(long, env = "UFOS_DATA")] 41 45 data: PathBuf, 42 46 /// DEBUG: don't start the jetstream consumer or its write loop 43 43 - #[arg(long, action)] 47 47 + #[arg(long, action, env = "UFOS_PAUSE_WRITER")] 44 48 pause_writer: bool, 45 49 /// Adjust runtime settings like background task intervals for efficient backfill 46 46 - #[arg(long, action)] 50 50 + #[arg(long, action, env = "UFOS_BACKFILL_MODE")] 47 51 backfill: bool, 48 52 /// DEBUG: force the rw loop to fall behind by pausing it 49 53 /// todo: restore this 50 54 #[arg(long, action)] 51 55 pause_rw: bool, 52 56 /// reset the rollup cursor, scrape through missed things in the past (backfill) 53 53 - #[arg(long, action)] 57 57 + #[arg(long, action, env = "UFOS_REROLL")] 54 58 reroll: bool, 55 59 /// DEBUG: interpret jetstream as a file fixture 56 56 - #[arg(long, action)] 60 60 + #[arg(long, action, env = "UFOS_JETSTREAM_FIXTURE")] 57 61 jetstream_fixture: bool, 58 58 - /// ufos server's listen address 59 59 - #[arg(long, default_value = "0.0.0.0:9990")] 60 60 - bind: std::net::SocketAddr, 62 62 + /// enable metrics collection and serving 63 63 + #[arg(long, action, env = "UFOS_COLLECT_METRICS")] 64 64 + collect_metrics: bool, 61 65 /// metrics server's listen address 62 62 - #[arg(long, default_value = "0.0.0.0:8765")] 66 66 + #[arg(long, env = "UFOS_BIND_METRICS")] 67 67 + #[clap(default_value = "0.0.0.0:8765")] 63 68 bind_metrics: std::net::SocketAddr, 64 69 } 65 70 ··· 143 148 Ok(()) 144 149 }); 145 150 146 146 - install_metrics_server(args.bind_metrics)?; 151 151 + if args.collect_metrics { 152 152 + log::trace!("installing metrics server..."); 153 153 + install_metrics_server(args.bind_metrics)?; 154 154 + } 147 155 148 156 for (i, t) in consumer_tasks.join_all().await.iter().enumerate() { 149 157 log::warn!("task {i} done: {t:?}");

+4 -1

ufos/src/server/mod.rs

Reviewed

··· 716 716 .await 717 717 } 718 718 719 719 - pub async fn serve(storage: impl StoreReader + 'static, bind: std::net::SocketAddr) -> Result<(), String> { 719 719 + pub async fn serve( 720 720 + storage: impl StoreReader + 'static, 721 721 + bind: std::net::SocketAddr, 722 722 + ) -> Result<(), String> { 720 723 describe_metrics(); 721 724 let log = ConfigLogging::StderrTerminal { 722 725 level: ConfigLoggingLevel::Warn,

+1 -1

who-am-i/Cargo.toml

Reviewed

··· 11 11 axum = "0.8.4" 12 12 axum-extra = { version = "0.10.1", features = ["cookie-signed", "typed-header"] } 13 13 axum-template = { version = "3.0.0", features = ["handlebars"] } 14 14 - clap = { version = "4.5.40", features = ["derive", "env"] } 14 14 + clap = { workspace = true } 15 15 ctrlc = "3.4.7" 16 16 dashmap = "6.1.0" 17 17 elliptic-curve = "0.13.8"